Sign upLogin

locomotivecms/engine

View on GitHub
Star
lib/locomotive/action_controller/responder.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method with_flash_message has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def with_flash_message(type = :notice, in_header = true)
        unless set_flash_message?
          yield if block_given?
          return
        end
Severity: Minor
Found in lib/locomotive/action_controller/responder.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method to_json has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def to_json
        add_authenticated_header

        if get?
          add_pagination_header if resource.respond_to?(:total_pages)
Severity: Minor
Found in lib/locomotive/action_controller/responder.rb - About 1 hr to fix

    Method to_json has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_json
        add_authenticated_header

        if get?
          add_pagination_header if resource.respond_to?(:total_pages)
    Severity: Minor
    Found in lib/locomotive/action_controller/responder.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status