Sign upLogin

locomotivecms/mounter

View on GitHub
Star
lib/locomotive/mounter/engine_api.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

      def self.update(resource_name, id, attributes, locale = nil, attribute_names = nil)
Severity: Minor
Found in lib/locomotive/mounter/engine_api.rb - About 35 mins to fix

    Method fetch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.fetch(resource_name, query = {}, locale = nil, attribute_names = nil)
        params = { query: query || {} }
        params[:query][:locale] = locale if locale

        url       = "/#{resource_name}.json"
    Severity: Minor
    Found in lib/locomotive/mounter/engine_api.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method paginated_each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def paginated_each(&block)
        loop do
          self.params[:query][:page] = self.page

          response  = Locomotive::Mounter::EngineApi.get(self.url, self.params)
    Severity: Minor
    Found in lib/locomotive/mounter/engine_api.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status