Sign upLogin

loganhenson/firstdata

View on GitHub
Star
src/Transaction.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method Purchase has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function Purchase($credit_card_type, $cardholderName, $credit_card_number, $credit_card_expiry, $cvd_code, $amount){
Severity: Minor
Found in src/Transaction.php - About 45 mins to fix

    Method Refund has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function Refund($credit_card_type, $cardholderName, $transarmor_token, $credit_card_expiry, $cvd_code, $amount){
    Severity: Minor
    Found in src/Transaction.php - About 45 mins to fix

      Method LatePurchase has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function LatePurchase($credit_card_type, $cardholderName, $transarmor_token, $credit_card_expiry, $cvd_code, $amount){
      Severity: Minor
      Found in src/Transaction.php - About 45 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            function __construct($gateway_id, $password, $key_id, $key, $test_mode = false){
        Severity: Minor
        Found in src/Transaction.php - About 35 mins to fix

          Method PreAuth has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function PreAuth($credit_card_type, $cardholderName, $credit_card_number, $credit_card_expiry, $cvd_code){
          Severity: Minor
          Found in src/Transaction.php - About 35 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function Purchase($credit_card_type, $cardholderName, $credit_card_number, $credit_card_expiry, $cvd_code, $amount){

        $this->setTransactionType("00");
        $this->setCreditCardType($credit_card_type);
        $this->setCardholderName($cardholderName);
            Severity: Major
            Found in src/Transaction.php and 2 other locations - About 50 mins to fix
            src/Transaction.php on lines 118..130
            src/Transaction.php on lines 146..158

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function LatePurchase($credit_card_type, $cardholderName, $transarmor_token, $credit_card_expiry, $cvd_code, $amount){

        $this->setTransactionType("00");
        $this->setCreditCardType($credit_card_type);
        $this->setCardholderName($cardholderName);
            Severity: Major
            Found in src/Transaction.php and 2 other locations - About 50 mins to fix
            src/Transaction.php on lines 104..116
            src/Transaction.php on lines 146..158

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                public function Refund($credit_card_type, $cardholderName, $transarmor_token, $credit_card_expiry, $cvd_code, $amount){

        $this->setTransactionType("04");
        $this->setCreditCardType($credit_card_type);
        $this->setCardholderName($cardholderName);
            Severity: Major
            Found in src/Transaction.php and 2 other locations - About 50 mins to fix
            src/Transaction.php on lines 104..116
            src/Transaction.php on lines 118..130

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status