lib/LongitudeOne/Spatial/PHP/Types/AbstractPolygon.php
Avoid using LongitudeOne\Spatial\PHP\Types\count() function in for loops. Open
Open
for ($i = 0; $i < count($this->rings); ++$i) {
$rings[] = $this->getRing($i);
}- Read upRead up
- Exclude checks
CountInLoopExpression
Since: 2.7.0
Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.
Example
class Foo {
public function bar()
{
$array = array();
for ($i = 0; count($array); $i++) {
// ...
}
}
}Source https://phpmd.org/rules/design.html#countinloopexpression
Line exceeds 120 characters; contains 133 characters Open
Open
* @param null|int $srid Spatial Reference System Identifier- Exclude checks
Line exceeds 120 characters; contains 133 characters Open
Open
* @param (float|int)[][]|LineStringInterface|MultiPointInterface|PointInterface[]|PolygonInterface $ring Ring to add to geometry- Exclude checks