longitude-one/geo-parser

View on GitHub

Showing 43 of 45 total issues

Function minutes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function minutes(): string|int
    {
        // If using colon or minutes is an integer parse value
        if (Lexer::T_COLON === $this->nextSymbol || $this->lexer->isNextToken(Lexer::T_INTEGER)) {
            /** @var int $readMinutes */
Severity: Minor
Found in lib/LongitudeOne/Geo/String/Parser.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dataSourceFromDocumentation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function dataSourceFromDocumentation(): \Generator
    {
        // Simple single-signed values
        yield [[40, 45], [40, 45]];
        yield [[-40, -45], [-40, -45]];
Severity: Minor
Found in tests/LongitudeOne/Geo/String/Tests/ParserTest.php - About 1 hr to fix

    Function degrees has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function degrees(): float|int
        {
            // Reset symbol requirement
            if (Lexer::T_APOSTROPHE === $this->nextSymbol || Lexer::T_QUOTE === $this->nextSymbol) {
                $this->nextSymbol = Lexer::T_DEGREE;
    Severity: Minor
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    CASE statements must be defined using a colon
    Open

                case 's':

    Avoid too many return statements within this method.
    Open

                    return $this->nextSymbol = Lexer::T_QUOTE;
    Severity: Major
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->nextSymbol;
      Severity: Major
      Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this->nextSymbol = false;
        Severity: Major
        Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

          Function coordinate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function coordinate(): float|int
              {
                  // By default, don't change sign
                  $sign = false;
          
          
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Line exceeds 120 characters; contains 218 characters
          Open

                  yield ['44°58\'53.9N 93°19\'25.8"W', UnexpectedValueException::class, '[Syntax Error] line 0, col 11: Error: Expected LongitudeOne\Geo\String\Lexer::T_QUOTE, got "N" in value "44°58\'53.9N 93°19\'25.8"W"'];

          Line exceeds 120 characters; contains 229 characters
          Open

                  yield ['+40°N 45°W', UnexpectedValueException::class, '[Syntax Error] line 0, col 5: Error: Expected LongitudeOne\Geo\String\Lexer::T_INTEGER or LongitudeOne\Geo\String\Lexer::T_FLOAT, got "N" in value "+40°N 45°W"'];

          Line exceeds 120 characters; contains 187 characters
          Open

                  yield ['40N 45°W', UnexpectedValueException::class, '[Syntax Error] line 0, col 6: Error: Expected LongitudeOne\Geo\String\Lexer::T_CARDINAL_LON, got "°" in value "40N 45°W"'];

          Line exceeds 120 characters; contains 191 characters
          Open

                  yield ['40°W 45°E', UnexpectedValueException::class, '[Syntax Error] line 0, col 10: Error: Expected LongitudeOne\Geo\String\Lexer::T_CARDINAL_LAT, got "E" in value "40°W 45°E"'];

          Line exceeds 120 characters; contains 183 characters
          Open

                  yield ['55:34.22', UnexpectedValueException::class, '[Syntax Error] line 0, col 3: Error: Expected LongitudeOne\Geo\String\Lexer::T_INTEGER, got "34.22" in value "55:34.22"'];

          Line exceeds 120 characters; contains 128 characters
          Open

                  // Single values of unsigned integer degrees with degree symbol, decimal minutes with apostrophe, and cardinal direction

          Line exceeds 120 characters; contains 167 characters
          Open

                  // If a colon hasn't been matched, and next token is a number followed by degree symbol, when tuple separator is space instead of comma, this value is complete

          Line exceeds 120 characters; contains 124 characters
          Open

                  yield ['55°70.99\'', RangeException::class, '[Range Error] Error: Minutes greater than 60 in value "55°70.99\'"'];

          Line exceeds 120 characters; contains 225 characters
          Open

                  yield ['40N -45°W', UnexpectedValueException::class, '[Syntax Error] line 0, col 4: Error: Expected LongitudeOne\Geo\String\Lexer::T_INTEGER or LongitudeOne\Geo\String\Lexer::T_FLOAT, got "-" in value "40N -45°W"'];

          Line exceeds 120 characters; contains 148 characters
          Open

                  yield ['40 45W', UnexpectedValueException::class, '[Syntax Error] line 0, col 5: Error: Expected end of string, got "W" in value "40 45W"'];

          Line exceeds 120 characters; contains 229 characters
          Open

                  yield ['-40°N 45°W', UnexpectedValueException::class, '[Syntax Error] line 0, col 5: Error: Expected LongitudeOne\Geo\String\Lexer::T_INTEGER or LongitudeOne\Geo\String\Lexer::T_FLOAT, got "N" in value "-40°N 45°W"'];

          Line exceeds 120 characters; contains 225 characters
          Open

                  yield ['40°N -45W', UnexpectedValueException::class, '[Syntax Error] line 0, col 6: Error: Expected LongitudeOne\Geo\String\Lexer::T_INTEGER or LongitudeOne\Geo\String\Lexer::T_FLOAT, got "-" in value "40°N -45W"'];
          Severity
          Category
          Status
          Source
          Language