Sign upLogin

longitude-one/geo-parser

View on GitHub
Star

Showing 7 of 45 total issues

Function minutes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    private function minutes(): string|int
    {
        // If using colon or minutes is an integer parse value
        if (Lexer::T_COLON === $this->nextSymbol || $this->lexer->isNextToken(Lexer::T_INTEGER)) {
            /** @var int $readMinutes */
Severity: Minor
Found in lib/LongitudeOne/Geo/String/Parser.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method dataSourceFromDocumentation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function dataSourceFromDocumentation(): \Generator
    {
        // Simple single-signed values
        yield [[40, 45], [40, 45]];
        yield [[-40, -45], [-40, -45]];
Severity: Minor
Found in tests/LongitudeOne/Geo/String/Tests/ParserTest.php - About 1 hr to fix

    Function degrees has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function degrees(): float|int
    {
        // Reset symbol requirement
        if (Lexer::T_APOSTROPHE === $this->nextSymbol || Lexer::T_QUOTE === $this->nextSymbol) {
            $this->nextSymbol = Lexer::T_DEGREE;
    Severity: Minor
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return $this->nextSymbol = Lexer::T_QUOTE;
    Severity: Major
    Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->nextSymbol;
      Severity: Major
      Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return $this->nextSymbol = false;
        Severity: Major
        Found in lib/LongitudeOne/Geo/String/Parser.php - About 30 mins to fix

          Function coordinate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function coordinate(): float|int
    {
        // By default, don't change sign
        $sign = false;
          Severity: Minor
          Found in lib/LongitudeOne/Geo/String/Parser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language