File Parser.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/**
 * This file is part of the LongitudeOne WKB-Parser project.
 *

Parser has 30 functions (exceeds 20 allowed). Consider refactoring.

Open

class Parser
{
    public const TYPE_CIRCULARSTRING = 'CircularString';
    public const TYPE_COMPOUNDCURVE = 'CompoundCurve';
    public const TYPE_CURVEPOLYGON = 'CurvePolygon';

The class Parser has an overall complexity of 68 which is very high. The configured complexity threshold is 50.

Open

class Parser
{
    public const TYPE_CIRCULARSTRING = 'CircularString';
    public const TYPE_COMPOUNDCURVE = 'CompoundCurve';
    public const TYPE_CURVEPOLYGON = 'CurvePolygon';

• Exclude checks
  • Disable engine
  • Disable check

Method readGeometry has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function readGeometry(): array
    {
        $srid = null;

        try {

Method geometryCollection has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private function geometryCollection(): array
    {
        $values = [];
        $count = $this->readCount();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for ($i = 0; $i < $count; ++$i) {
            $this->readByteOrder();

            $type = $this->readType();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for ($i = 0; $i < $count; ++$i) {
            $this->readByteOrder();

            $type = $this->readType();

• Read up
  Read up

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 16 and the first side effect is on line 14.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 75 and the first side effect is on line 21.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

Possible parse error: class missing opening or closing brace

Open

class Parser

• Exclude checks
  • Disable engine
  • Disable check

Possible parse error: class missing opening or closing brace

Open

class Parser

• Exclude checks
  • Disable engine
  • Disable check

Function getBadTypeInTypeMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    private function getBadTypeInTypeMessage(int $childType, int $parentType, array $expectedTypes)
    {
        if ($this->type !== $parentType) {
            $parentType = $this->type;
        }

• Read up
  Read up

The method getBadTypeInTypeMessage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

        } else {
            $message = 'Bad'.$message;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

The method getBadTypeInTypeMessage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $last = $this->getTypeName(array_pop($expectedTypes));
                $message .= implode(', ', array_map([$this, 'getTypeName'], $expectedTypes)).' or '.$last;
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Avoid unused private methods such as 'onWarning'.

Open

    private function onWarning(int $errorNumber, string $errorMessage): void
    {
        throw $this->getInvalidArgumentException($errorNumber, $errorMessage);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something
{
    private function foo() {} // unused
}

Line exceeds 120 characters; contains 213 characters

Open

                    throw new UnexpectedValueException($this->getBadTypeInTypeMessage($type, self::WKB_TYPE_CURVEPOLYGON, [self::WKB_TYPE_LINESTRING, self::WKB_TYPE_CIRCULARSTRING, self::WKB_TYPE_COMPOUNDCURVE]));

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 149 characters

Open

     * This value can be point|line-string|multiPoint|polygon|multiLineString|multiPolygon|compoundCurve||multiCurve|multiSurface| polyhedralSurface,

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 191 characters

Open

                default => throw new UnexpectedValueException($this->getBadTypeInTypeMessage($type, self::WKB_TYPE_COMPOUNDCURVE, [self::WKB_TYPE_LINESTRING, self::WKB_TYPE_CIRCULARSTRING])),

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 919 characters

Open

     * @return array{type:string, srid: ?int, value: (float|int)[]|(float|int)[][]|(float|int)[][][]|(float|int)[][][][]|(float|int)[][][][][]|array{type: string, value:(float|int)[][]}[]|array{type: string, value:(float|int)[][]|array{type: string, value:(float|int)[][]}[]}[]|array{type: string, value:(float|int)[][][]|array{type: string, value:(float|int)[][]|array{type: string, value:(float|int)[][]}[]}[]}[]|array{type: string, value:(float|int)[][][]}[]|array{type:string, value:(float|int)[]|(float|int)[][]|(float|int)[][][]|(float|int)[][][][]|(float|int)[][][][][]|array{type: string, value:(float|int)[][]}[]|array{type: string, value:(float|int)[][]|array{type: string, value:(float|int)[][]}[]}[]|array{type: string, value:(float|int)[][][]|array{type: string, value:(float|int)[][]|array{type: string, value:(float|int)[][]}[]}[]}[]|array{type: string, value:(float|int)[][][]}[]}[], dimension: ?string}

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 151 characters

Open

                throw new UnexpectedValueException($this->getBadTypeInTypeMessage($type, self::WKB_TYPE_MULTILINESTRING, [self::WKB_TYPE_LINESTRING]));

• Exclude checks
  • Disable engine
  • Disable check