longitude-one/wkb-parser

View on GitHub

Showing 5 of 211 total issues

File Parser.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the LongitudeOne WKB-Parser project.
 *
Severity: Minor
Found in lib/LongitudeOne/Geo/WKB/Parser.php - About 6 hrs to fix

    Parser has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Parser
    {
        public const TYPE_CIRCULARSTRING = 'CircularString';
        public const TYPE_COMPOUNDCURVE = 'CompoundCurve';
        public const TYPE_CURVEPOLYGON = 'CurvePolygon';
    Severity: Minor
    Found in lib/LongitudeOne/Geo/WKB/Parser.php - About 3 hrs to fix

      Method readGeometry has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function readGeometry(): array
          {
              $srid = null;
      
              try {
      Severity: Minor
      Found in lib/LongitudeOne/Geo/WKB/Parser.php - About 1 hr to fix

        Method geometryCollection has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function geometryCollection(): array
            {
                $values = [];
                $count = $this->readCount();
        
        
        Severity: Minor
        Found in lib/LongitudeOne/Geo/WKB/Parser.php - About 1 hr to fix

          Function getBadTypeInTypeMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function getBadTypeInTypeMessage(int $childType, int $parentType, array $expectedTypes)
              {
                  if ($this->type !== $parentType) {
                      $parentType = $this->type;
                  }
          Severity: Minor
          Found in lib/LongitudeOne/Geo/WKB/Parser.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language