Sign upLogin

loolaz/redis-mutex-semaphore

View on GitHub
Star

Showing 18 of 18 total issues

Function factory has 331 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.factory = function(connect_options, cb){
    var    mutexTimer = {},
        SharedObjectFactory = function(connect_options, cb) {        
            if(connect_options && connect_options.options){
                this.client = connect_options;
Severity: Major
Found in lib/factory.js - About 1 day to fix

    Function factory has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.factory = function(connect_options, cb){
    var    mutexTimer = {},
        SharedObjectFactory = function(connect_options, cb) {        
            if(connect_options && connect_options.options){
                this.client = connect_options;
    Severity: Minor
    Found in lib/factory.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File sharedObject.js has 349 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

var EventEmitter = require('events'),
    util = require('util'),
    uuid = require('uuid'),
    Severity: Minor
    Found in lib/sharedObject.js - About 4 hrs to fix

      File factory.js has 345 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';

var Promise = require('bluebird'),
    redis = require('redis'),
    util = require('util'),
      Severity: Minor
      Found in lib/factory.js - About 4 hrs to fix

        Function makeWaitingFunc has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        SharedObject.prototype.makeWaitingFunc = function(priori){
    var that = this;

    return function(timeout, cb, _cb, pushback){        
        if(cb && typeof cb === "function"){
        Severity: Major
        Found in lib/sharedObject.js - About 2 hrs to fix

          Function observing has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          SharedObject.prototype.observing = function(timeout, cb, _cb){
    var that = this;

    if(cb && typeof cb === "function"){
        var p = that.check();
          Severity: Minor
          Found in lib/sharedObject.js - About 1 hr to fix

            Function _extend has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                Mutex.prototype._extend = function(muid, timeout){
        var that = this,
            newTimeout = that.timeout - (Date.now() - that.timestamp) + (timeout * 1000);
        return new Promise(function(resolve, reject){        
            that._evalJustInTime('extend', 1, that.key, muid, newTimeout, function(err, result){
            Severity: Minor
            Found in lib/factory.js - About 1 hr to fix

              Function onRel has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              SharedObject.prototype.onRel = function(channel, message){
    var that = this,
        count = 0,
        sortedKeys = Object.keys(that.waitingList).sort(function(a, b){
            return parseInt(a, 10) > parseInt(b, 10);
              Severity: Minor
              Found in lib/sharedObject.js - About 1 hr to fix

                Function _getStatus has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                SharedObject.prototype._getStatus = function(timeout){ /* mil sec. */
    var that = this;
    
    return new Promise(function(resolve, reject){
        var token = uuid.v4();
                Severity: Minor
                Found in lib/sharedObject.js - About 1 hr to fix

                  Function _get has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      Mutex.prototype._get = function(){
        var that = this,
            muid = uuid.v4(),
            startTime = Date.now(),
            setMutexTimer = function(){
                  Severity: Minor
                  Found in lib/factory.js - About 1 hr to fix

                    Function _initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        _._initialize = function(cb){
        var that = this;
        that.prefixSemaphore = 'sema:';
        that.prefixMutex = 'mutex:';
        that.sharedObjects = {};
                    Severity: Minor
                    Found in lib/factory.js - About 1 hr to fix

                      Function _rel has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          Mutex.prototype._rel = function(muid){
        var that = this;
        return new Promise(function(resolve, reject){        
            that._evalJustInTime('rel', 1, that.key, muid, function(err, reply){
                if(err){
                      Severity: Minor
                      Found in lib/factory.js - About 1 hr to fix

                        Function Mutex has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            function Mutex(object, prefix, client, subscriber, timeout){
                        Severity: Minor
                        Found in lib/factory.js - About 35 mins to fix

                          Function Semaphore has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              function Semaphore(object, count, prefix, client, subscriber) {
                          Severity: Minor
                          Found in lib/factory.js - About 35 mins to fix

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if(!{}.hasOwnProperty.call(that.sharedObjects, that.prefixMutex+object)){
            that._createMutex(object, timeout);
        }
                            Severity: Minor
                            Found in lib/factory.js and 2 other locations - About 35 mins to fix
                            lib/factory.js on lines 331..333
                            lib/factory.js on lines 340..342

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if(!{}.hasOwnProperty.call(that.sharedObjects, that.prefixSemaphore+object)){
            that._createSemaphore(object, count);
        }
                            Severity: Minor
                            Found in lib/factory.js and 2 other locations - About 35 mins to fix
                            lib/factory.js on lines 331..333
                            lib/factory.js on lines 355..357

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 3 locations. Consider refactoring.
                            Open

                                    if(!{}.hasOwnProperty.call(that.sharedObjects, that.prefixSemaphore+object)){
            that._createSemaphore(object, count);
        }
                            Severity: Minor
                            Found in lib/factory.js and 2 other locations - About 35 mins to fix
                            lib/factory.js on lines 340..342
                            lib/factory.js on lines 355..357

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Function onRel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                            Open

                            SharedObject.prototype.onRel = function(channel, message){
    var that = this,
        count = 0,
        sortedKeys = Object.keys(that.waitingList).sort(function(a, b){
            return parseInt(a, 10) > parseInt(b, 10);
                            Severity: Minor
                            Found in lib/sharedObject.js - About 35 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language