Sign upLogin

loolaz/redis-mutex-semaphore

View on GitHub
Star
lib/sharedObject.js

Summary

Maintainability
C
1 day
Test Coverage

File sharedObject.js has 349 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

var EventEmitter = require('events'),
    util = require('util'),
    uuid = require('uuid'),
Severity: Minor
Found in lib/sharedObject.js - About 4 hrs to fix

    Function makeWaitingFunc has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    SharedObject.prototype.makeWaitingFunc = function(priori){
    var that = this;

    return function(timeout, cb, _cb, pushback){        
        if(cb && typeof cb === "function"){
    Severity: Major
    Found in lib/sharedObject.js - About 2 hrs to fix

      Function observing has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      SharedObject.prototype.observing = function(timeout, cb, _cb){
    var that = this;

    if(cb && typeof cb === "function"){
        var p = that.check();
      Severity: Minor
      Found in lib/sharedObject.js - About 1 hr to fix

        Function onRel has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        SharedObject.prototype.onRel = function(channel, message){
    var that = this,
        count = 0,
        sortedKeys = Object.keys(that.waitingList).sort(function(a, b){
            return parseInt(a, 10) > parseInt(b, 10);
        Severity: Minor
        Found in lib/sharedObject.js - About 1 hr to fix

          Function _getStatus has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          SharedObject.prototype._getStatus = function(timeout){ /* mil sec. */
    var that = this;
    
    return new Promise(function(resolve, reject){
        var token = uuid.v4();
          Severity: Minor
          Found in lib/sharedObject.js - About 1 hr to fix

            Function onRel has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            SharedObject.prototype.onRel = function(channel, message){
    var that = this,
        count = 0,
        sortedKeys = Object.keys(that.waitingList).sort(function(a, b){
            return parseInt(a, 10) > parseInt(b, 10);
            Severity: Minor
            Found in lib/sharedObject.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status