Sign upLogin

loomio/loomio

View on GitHub
Star
app/mailers/event_mailer.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method event has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def event(recipient_id, event_id)
    @current_user = @recipient = User.active.find_by!(id: recipient_id)
    @event = Event.find_by!(id: event_id)
    @notification = Notification.find_by(user_id: recipient_id, event_id: event_id)
Severity: Major
Found in app/mailers/event_mailer.rb - About 2 hrs to fix

    Method event has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def event(recipient_id, event_id)
    @current_user = @recipient = User.active.find_by!(id: recipient_id)
    @event = Event.find_by!(id: event_id)
    @notification = Notification.find_by(user_id: recipient_id, event_id: event_id)
    Severity: Minor
    Found in app/mailers/event_mailer.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reply_to_address_with_group_name has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def reply_to_address_with_group_name(model:, user:)
    return nil unless user.is_logged_in?
    return nil unless model.respond_to?(:discussion) && model.discussion.present?
    if model.discussion.group.present?
      "\"#{I18n.transliterate(model.discussion.group.full_name).truncate(50).delete('"')}\" <#{reply_to_address(model: model, user: user)}>"
    Severity: Minor
    Found in app/mailers/event_mailer.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status