Sign upLogin

lotoss/project-lvl2-s257

View on GitHub
Star

Showing 10 of 10 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe('nesting config', () => {
    const beforeJsonPath = resolve(__dirname, './__fixtures__/nesting/before.json');
    const afterJsonPath = resolve(__dirname, './__fixtures__/nesting/after.json');

    const beforeYamlPath = resolve(__dirname, './__fixtures__/nesting/before.yml');
Severity: Major
Found in __tests__/gendiff.test.js and 1 other location - About 2 days to fix
__tests__/gendiff.test.js on lines 8..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 384.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  describe('plain config', () => {
    const beforeJsonPath = resolve(__dirname, './__fixtures__/plain/before.json');
    const afterJsonPath = resolve(__dirname, './__fixtures__/plain/after.json');

    const beforeYamlPath = resolve(__dirname, './__fixtures__/plain/before.yml');
Severity: Major
Found in __tests__/gendiff.test.js and 1 other location - About 2 days to fix
__tests__/gendiff.test.js on lines 55..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 384.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function make has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const make = (key, prevValue, nextValue) => {
  const types = {
    nested: {
      make: () => {
        const keysUnion = union(Object.keys(prevValue), Object.keys(nextValue));
Severity: Minor
Found in src/ast/node.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        removed: {
      make: () => attach('RemovedNode', { key, value: prevValue }),
      predicate: () => prevValue !== undefined && nextValue === undefined,
    },
    Severity: Minor
    Found in src/ast/node.js and 1 other location - About 45 mins to fix
    src/ast/node.js on lines 17..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        added: {
      make: () => attach('AddedNode', { key, value: nextValue }),
      predicate: () => prevValue === undefined && nextValue !== undefined,
    },
    Severity: Minor
    Found in src/ast/node.js and 1 other location - About 45 mins to fix
    src/ast/node.js on lines 21..24

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        RemovedNode: () => spaced(2, true)(flatten([renderKeyValue(`- ${getKey(node)}`, stringify(getValue(node)))])),
    Severity: Minor
    Found in src/render/pretty.js and 1 other location - About 40 mins to fix
    src/render/pretty.js on lines 44..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        AddedNode: () => spaced(2, true)(flatten([renderKeyValue(`+ ${getKey(node)}`, stringify(getValue(node)))])),
    Severity: Minor
    Found in src/render/pretty.js and 1 other location - About 40 mins to fix
    src/render/pretty.js on lines 45..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function spaced has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    const spaced = (count, skipFirstString) => (arg) => {
  if (!Array.isArray(arg)) {
    return `${' '.repeat(count)}${arg}`;
  }
  return arg.map((str, idx) => {
    Severity: Minor
    Found in src/render/pretty.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const render = (node) => {
  const renders = {
    NotChangedNode: () =>
      flatten([spaced(2)(renderKeyValue(getKey(node), stringify(getValue(node))))]),
    AddedNode: () => spaced(2, true)(flatten([renderKeyValue(`+ ${getKey(node)}`, stringify(getValue(node)))])),
    Severity: Minor
    Found in src/render/pretty.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function make has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const make = (key, prevValue, nextValue) => {
  const types = {
    nested: {
      make: () => {
        const keysUnion = union(Object.keys(prevValue), Object.keys(nextValue));
    Severity: Minor
    Found in src/ast/node.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language