Sign upLogin

louismullie/treat

View on GitHub
Star
lib/treat/workers/formatters/unserializers/xml.rb

Summary

Maintainability
D
2 days
Test Coverage

Method unserialize has a Cognitive Complexity of 86 (exceeds 5 allowed). Consider refactoring.
Open

  def self.unserialize(document, options = {})
    # Read in the XML file.
    xml = File.read(document.file)
    xml.gsub!('<treat>', '')
    xml.gsub!('</treat>', '')
Severity: Minor
Found in lib/treat/workers/formatters/unserializers/xml.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method unserialize has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.unserialize(document, options = {})
    # Read in the XML file.
    xml = File.read(document.file)
    xml.gsub!('<treat>', '')
    xml.gsub!('</treat>', '')
Severity: Major
Found in lib/treat/workers/formatters/unserializers/xml.rb - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                v = true if v == 'true'
    Severity: Major
    Found in lib/treat/workers/formatters/unserializers/xml.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  v = ":".intern if v == :''
      Severity: Major
      Found in lib/treat/workers/formatters/unserializers/xml.rb - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                    v = v.to_i if v =~ /^[0-9]*$/
        Severity: Major
        Found in lib/treat/workers/formatters/unserializers/xml.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      v = v[1..-1].intern if v[0] == ':'
          Severity: Major
          Found in lib/treat/workers/formatters/unserializers/xml.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        v = v.to_f if v =~ /^[0-9\.]*$/
            Severity: Major
            Found in lib/treat/workers/formatters/unserializers/xml.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          v = false if v == 'false'
              Severity: Major
              Found in lib/treat/workers/formatters/unserializers/xml.rb - About 45 mins to fix

                There are no issues that match your filters.

                Category
                Status