louismullie/treat

View on GitHub
lib/treat/workers/lexicalizers/categorizers/from_tag.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method category has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def self.category(entity, options = {})

    tag = entity.check_has(:tag)
    
    return 'unknown' if tag.nil? || tag == ''
Severity: Minor
Found in lib/treat/workers/lexicalizers/categorizers/from_tag.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method category has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.category(entity, options = {})

    tag = entity.check_has(:tag)
    
    return 'unknown' if tag.nil? || tag == ''
Severity: Minor
Found in lib/treat/workers/lexicalizers/categorizers/from_tag.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return :unknown if cat == nil
    Severity: Major
    Found in lib/treat/workers/lexicalizers/categorizers/from_tag.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return cat[ts]
      Severity: Major
      Found in lib/treat/workers/lexicalizers/categorizers/from_tag.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

            return Ptc[entity.to_s] if entity.type == :punctuation
        Severity: Major
        Found in lib/treat/workers/lexicalizers/categorizers/from_tag.rb - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status