lovata/oc-toolbox-plugin

View on GitHub

Showing 227 of 236 total issues

File ElementCollection.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php namespace Lovata\Toolbox\Classes\Collection;

use ArrayIterator;
use October\Contracts\Twig\CallsAnyMethod;
use October\Rain\Extension\Extendable;
Severity: Minor
Found in classes/collection/ElementCollection.php - About 6 hrs to fix

    ElementCollection has 40 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class ElementCollection extends Extendable implements CallsAnyMethod, \IteratorAggregate, \Countable
    {
        const COUNT_PER_PAGE = 10;
        const ITEM_CLASS = \Lovata\Toolbox\Classes\Item\ElementItem::class;
    
    
    Severity: Minor
    Found in classes/collection/ElementCollection.php - About 5 hrs to fix

      File CommonCreateFile.php has 371 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php namespace Lovata\Toolbox\Classes\Console;
      
      use Lang;
      use Illuminate\Console\Command;
      use Symfony\Component\Console\Input\InputArgument;
      Severity: Minor
      Found in classes/console/CommonCreateFile.php - About 4 hrs to fix

        ElementItem has 31 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class ElementItem extends MainItem
        {
            use ExtendableTrait;
        
            const MODEL_CLASS = Model::class;
        Severity: Minor
        Found in classes/item/ElementItem.php - About 3 hrs to fix

          File CommonProperty.php has 316 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php namespace Lovata\Toolbox\Models;
          
          use Lang;
          use Backend\Models\ImportModel;
          use October\Rain\Database\Traits\Validation;
          Severity: Minor
          Found in models/CommonProperty.php - About 3 hrs to fix

            File ElementItem.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php namespace Lovata\Toolbox\Classes\Item;
            
            use Model;
            use October\Rain\Extension\ExtendableTrait;
            
            
            Severity: Minor
            Found in classes/item/ElementItem.php - About 3 hrs to fix

              The class ElementCollection has an overall complexity of 112 which is very high. The configured complexity threshold is 50.
              Open

              abstract class ElementCollection extends Extendable implements CallsAnyMethod, \IteratorAggregate, \Countable
              {
                  const COUNT_PER_PAGE = 10;
                  const ITEM_CLASS = \Lovata\Toolbox\Classes\Item\ElementItem::class;
              
              

              The class AbstractImportModel has an overall complexity of 66 which is very high. The configured complexity threshold is 50.
              Open

              abstract class AbstractImportModel
              {
                  use TraitInitActiveLang;
              
                  const EVENT_BEFORE_IMPORT = 'model.beforeImport';

              The class AbstractImportModelFromXML has an overall complexity of 56 which is very high. The configured complexity threshold is 50.
              Open

              abstract class AbstractImportModelFromXML extends AbstractImportModel
              {
                  const EXTEND_FIELD_LIST = '';
                  const EXTEND_IMPORT_DATA = '';
                  const PARSE_NODE_CLASS = ParseXMLNode::class;

              The class CommonCreateFile has an overall complexity of 79 which is very high. The configured complexity threshold is 50.
              Open

              class CommonCreateFile extends Command
              {
                  use LogoTrait;
              
                  const PREFIX_LOWER   = 'lower_';
              Severity: Minor
              Found in classes/console/CommonCreateFile.php by phpmd

              The class ElementCollection has 31 public methods. Consider refactoring ElementCollection to keep number of public methods under 10.
              Open

              abstract class ElementCollection extends Extendable implements CallsAnyMethod, \IteratorAggregate, \Countable
              {
                  const COUNT_PER_PAGE = 10;
                  const ITEM_CLASS = \Lovata\Toolbox\Classes\Item\ElementItem::class;
              
              

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class ElementItem has an overall complexity of 88 which is very high. The configured complexity threshold is 50.
              Open

              abstract class ElementItem extends MainItem
              {
                  use ExtendableTrait;
              
                  const MODEL_CLASS = Model::class;
              Severity: Minor
              Found in classes/item/ElementItem.php by phpmd

              The class CommonProperty has an overall complexity of 57 which is very high. The configured complexity threshold is 50.
              Open

              class CommonProperty extends ImportModel
              {
                  const NAME = 'property';
              
                  use Validation;
              Severity: Minor
              Found in models/CommonProperty.php by phpmd

              The class ElementItem has 17 public methods. Consider refactoring ElementItem to keep number of public methods under 10.
              Open

              abstract class ElementItem extends MainItem
              {
                  use ExtendableTrait;
              
                  const MODEL_CLASS = Model::class;
              Severity: Minor
              Found in classes/item/ElementItem.php by phpmd

              TooManyPublicMethods

              Since: 0.1

              A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

              The class ElementCollection has 34 non-getter- and setter-methods. Consider refactoring ElementCollection to keep number of methods under 25.
              Open

              abstract class ElementCollection extends Extendable implements CallsAnyMethod, \IteratorAggregate, \Countable
              {
                  const COUNT_PER_PAGE = 10;
                  const ITEM_CLASS = \Lovata\Toolbox\Classes\Item\ElementItem::class;
              
              

              TooManyMethods

              Since: 0.1

              A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

              By default it ignores methods starting with 'get' or 'set'.

              The default was changed from 10 to 25 in PHPMD 2.3.

              Example

              Source https://phpmd.org/rules/codesize.html#toomanymethods

              Function importImageList has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function importImageList()
                  {
                      if (!$this->bNeedUpdateImageList) {
                          return;
                      }
              Severity: Minor
              Found in classes/helper/AbstractImportModel.php - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method handle has 77 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function handle()
                  {
                      $this->logoToolBox();
              
                      $arHeaderList = [self::HEADER_COMMAND_LIST, self::HEADER_DESCRIPTION];
              Severity: Major
              Found in classes/console/ToolBoxHelper.php - About 3 hrs to fix

                Function getUrlParamList has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function getUrlParamList($sPageCode, $sComponentName, $sParamName = 'slug', $bFindWildcard = false)
                    {
                        $sCacheKey = implode('_', [$sPageCode, $sComponentName, $sParamName, (int) $bFindWildcard]);
                        if ($this->hasCache($sCacheKey)) {
                            return $this->getCachedData($sCacheKey);
                Severity: Minor
                Found in classes/helper/PageHelper.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function parse has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function parse()
                    {
                        if (empty($this->arImportSettings)) {
                            return;
                        }
                Severity: Minor
                Found in classes/helper/ParseXMLNode.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    protected function setModel()
                    {
                        if ($this->checkAdditionList(self::CODE_MODEL)) {
                            return;
                        }
                Severity: Major
                Found in classes/console/CommonCreateFile.php and 1 other location - About 2 hrs to fix
                classes/console/CommonCreateFile.php on lines 247..261

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 90.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language