Sign upLogin

lstejskal/adapi

View on GitHub
Star
lib/adapi/campaign.rb

Summary

Maintainability
C
1 day
Test Coverage

Method update_ad_groups! has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def update_ad_groups!(ad_groups = [])
      return true if ad_groups.nil? or ad_groups.empty?

      # FIXME deep symbolize_keys
      ad_groups.map! { |ag| ag.symbolize_keys }
Severity: Minor
Found in lib/adapi/campaign.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    def create
      return false unless self.valid?      
      
      # set defaults for budget for campaign.create only
      self.budget = budget.reverse_merge( period: 'DAILY', delivery_method: 'STANDARD' )
Severity: Minor
Found in lib/adapi/campaign.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method find has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def self.find(amount = :all, params = {})
      # find single campaign by id
      if params.empty? and not amount.is_a?(Symbol)
        params[:id] = amount.to_i
        amount = :first
Severity: Minor
Found in lib/adapi/campaign.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def create
      return false unless self.valid?      
      
      # set defaults for budget for campaign.create only
      self.budget = budget.reverse_merge( period: 'DAILY', delivery_method: 'STANDARD' )
Severity: Minor
Found in lib/adapi/campaign.rb - About 1 hr to fix

    Method update_ad_groups! has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def update_ad_groups!(ad_groups = [])
      return true if ad_groups.nil? or ad_groups.empty?

      # FIXME deep symbolize_keys
      ad_groups.map! { |ag| ag.symbolize_keys }
    Severity: Minor
    Found in lib/adapi/campaign.rb - About 1 hr to fix

      Method find has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.find(amount = :all, params = {})
      # find single campaign by id
      if params.empty? and not amount.is_a?(Symbol)
        params[:id] = amount.to_i
        amount = :first
      Severity: Minor
      Found in lib/adapi/campaign.rb - About 1 hr to fix

        Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def update(params = {})
      # REFACTOR for the moment, we use separate campaign object just to prepare and execute 
      # campaign update request. This is kinda ugly and should be eventually refactored (if
      # only because of weird transfer of potential errors later when dealing with response). 
      #
        Severity: Minor
        Found in lib/adapi/campaign.rb - About 1 hr to fix

          Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def update(params = {})
      # REFACTOR for the moment, we use separate campaign object just to prepare and execute 
      # campaign update request. This is kinda ugly and should be eventually refactored (if
      # only because of weird transfer of potential errors later when dealing with response). 
      #
          Severity: Minor
          Found in lib/adapi/campaign.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                predicates = [ :id ].map do |param_name|
        if params[param_name]
          # convert to array
          value = Array.try_convert(params[param_name]) ? params_param_name : [params[param_name]]
          { field: param_name.to_s.camelcase, operator: 'IN', values: value }
          Severity: Minor
          Found in lib/adapi/campaign.rb and 1 other location - About 30 mins to fix
          lib/adapi/campaign_criterion.rb on lines 192..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status