Sign upLogin

lter/deims

View on GitHub
Star

Showing 699 of 699 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains BdpDataSet.
Severity: Major
Found in modules/custom/bdp/lib/BdpDataSet.php and 1 other location - About 2 days to fix
modules/custom/iso/lib/IsoDataSet.php on lines 1..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 468.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

/**
 * @file
 * Contains IsoDataSet.
Severity: Major
Found in modules/custom/iso/lib/IsoDataSet.php and 1 other location - About 2 days to fix
modules/custom/bdp/lib/BdpDataSet.php on lines 1..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 468.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getUnitOptions has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

  public static function getUnitOptions($category_minimum = 0) {
    $results = &drupal_static(__FUNCTION__);

    if (!isset($results)) {
      $cid = 'unit-options:' . $GLOBALS['language']->language;
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitHelper.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public function fetchEMLID() {
    list($scope, $identifier, $revision) = $this->dataSet->getPackageIDParts();

    $url = static::getApiUrl("package/eml/{$scope}/{$identifier}?filter=newest");
    $request = drupal_http_request($url, array('timeout' => 10));
Severity: Major
Found in modules/custom/pasta/sync_eml_id/lib/PastaEmlIdApi.php and 1 other location - About 4 hrs to fix
modules/custom/pasta/lib/PastaApi.php on lines 131..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  public function fetchEMLID() {
    list($scope, $identifier, $revision) = $this->dataSet->getPackageIDParts();

    $url = static::getApiUrl("package/eml/{$scope}/{$identifier}?filter=newest");
    $request = drupal_http_request($url, array('timeout' => 10));
Severity: Major
Found in modules/custom/pasta/lib/PastaApi.php and 1 other location - About 4 hrs to fix
modules/custom/pasta/sync_eml_id/lib/PastaEmlIdApi.php on lines 28..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 166.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getUnits has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  public static function getUnits() {
    $units = &drupal_static(__FUNCTION__);

    if (!isset($units)) {
      $cid = 'units:scope=2';
Severity: Minor
Found in modules/custom/lter_unit/lib/LterUnitHelper.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 81 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public function __construct(array $arguments) {
    $arguments += array(
      'description' => '',
      'source_connection' => 'drupal6',
      'source_version' => 6,
Severity: Major
Found in modules/custom/deims_d6_migration/migration/DeimsContentDataSetMigration.php - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!empty($variables)) {
      $query = $connection->select('content_field_var_missingvalues', 'c');
      $query->fields('c', array('nid', 'field_var_missingvalues_value'));
      $query->condition('vid', $vids, 'IN');
      $query->isNotNull('field_var_missingvalues_value');
    Severity: Major
    Found in modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php and 1 other location - About 3 hrs to fix
    modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php on lines 143..155

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!empty($variables)) {
      $query = $connection->select('content_field_code_definition', 'c');
      $query->fields('c', array('nid', 'field_code_definition_value'));
      $query->condition('vid', $vids, 'IN');
      $query->isNotNull('field_code_definition_value');
    Severity: Major
    Found in modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php and 1 other location - About 3 hrs to fix
    modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php on lines 159..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 144.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method getVariables has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public function getVariables($node, $row) {
    // We already have the array of referenced variable nodes in this row variable.
    // First filter out any NULL or empty values before proceeding.
    $variable_nids = array_filter($row->field_datafile_variable_ref);
    if (empty($variable_nids)) {
    Severity: Major
    Found in modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php - About 3 hrs to fix

      Method __construct has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        public function __construct(array $arguments) {
    $arguments += array(
      'description' => '',
      'source_connection' => 'drupal6',
      'source_version' => 6,
      Severity: Major
      Found in modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php - About 2 hrs to fix

        Function processData has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

          public static function processData(&$data) {
    try {
      if ($node = node_load($data['nid'])) {
        $dataset = new EmlDataSet($node);
        $pasta = new PastaApi($dataset);
        Severity: Minor
        Found in modules/custom/pasta/lib/PastaSubmissionQueue.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        <?php

/**
 * @file
 * Definition of DeimsContentBookMigration.
        Severity: Major
        Found in modules/custom/deims_d6_migration/migration/DeimsContentBookMigration.php and 2 other locations - About 2 hrs to fix
        modules/custom/deims_d6_migration/migration/DeimsContentPageMigration.php on lines 1..33
        modules/custom/deims_d6_migration/migration/DeimsContentStoryMigration.php on lines 1..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        <?php

/**
 * @file
 * Definition of DeimsContentPageMigration.
        Severity: Major
        Found in modules/custom/deims_d6_migration/migration/DeimsContentPageMigration.php and 2 other locations - About 2 hrs to fix
        modules/custom/deims_d6_migration/migration/DeimsContentBookMigration.php on lines 1..33
        modules/custom/deims_d6_migration/migration/DeimsContentStoryMigration.php on lines 1..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        <?php

/**
 * @file
 * Definition of DeimsContentStoryMigration.
        Severity: Major
        Found in modules/custom/deims_d6_migration/migration/DeimsContentStoryMigration.php and 2 other locations - About 2 hrs to fix
        modules/custom/deims_d6_migration/migration/DeimsContentBookMigration.php on lines 1..33
        modules/custom/deims_d6_migration/migration/DeimsContentPageMigration.php on lines 1..33

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method __construct has 53 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          public function __construct(array $arguments) {
    $arguments += array(
      'description' => '',
      'source_connection' => 'drupal6',
      'source_version' => 6,
        Severity: Major
        Found in modules/custom/deims_d6_migration/migration/DeimsContentPersonMigration.php - About 2 hrs to fix

          Function getVariables has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

            public function getVariables($node, $row) {
    // We already have the array of referenced variable nodes in this row variable.
    // First filter out any NULL or empty values before proceeding.
    $variable_nids = array_filter($row->field_datafile_variable_ref);
    if (empty($variable_nids)) {
          Severity: Minor
          Found in modules/custom/deims_d6_migration/migration/DeimsContentDataFileMigration.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function attach has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            attach: function (context) {

    $('select.variable-type.autocomplete-item-process').each(function() {
      $(this).removeClass('autocomplete-item-process');
          Severity: Minor
          Found in modules/custom/deims_variable_search/js/field.js - About 1 hr to fix

            Function getProjectRoles has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              public function getProjectRoles($node, $row) {
    $field_values = array();

    $roles = array(
      'field_dataset_datamanager_ref' => 'data manager',
            Severity: Minor
            Found in modules/custom/deims_d6_migration/migration/DeimsContentDataSetMigration.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function fetchDOI has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

              public function fetchDOI() {
    list($scope, $identifier, $revision) = $this->dataSet->getPackageIDParts();

    $url = static::getApiUrl("package/doi/eml/{$scope}/{$identifier}/{$revision}");
    $request = drupal_http_request($url, array('timeout' => 10));
            Severity: Minor
            Found in modules/custom/pasta/lib/PastaApi.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language