Sign upLogin

ltgcgo/octavia

View on GitHub
Star

Showing 43 of 44 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    for (let i = 0; i < 128; i ++) {
                        let entryStart = i * section.entryLen;
                        let entryWin = sectWin.subarray(entryStart, entryStart + section.entryLen);
                        let name = utf8Dec.decode(entryWin.subarray(0, 24)).trimEnd().replace("InitCombi", "");
                        if (name.length && prg > 12) {
Severity: Major
Found in src/state/bankDecoder.js and 1 other location - About 1 day to fix
src/state/bankDecoder.js on lines 164..171

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    for (let i = 0; i < 128; i ++) {
                        let entryStart = i * section.entryLen;
                        let entryWin = sectWin.subarray(entryStart, entryStart + section.entryLen);
                        let name = utf8Dec.decode(entryWin.subarray(0, 24)).trimEnd().replace("InitProg", "");
                        if (name.length && prg > 5) {
Severity: Major
Found in src/state/bankDecoder.js and 1 other location - About 1 day to fix
src/state/bankDecoder.js on lines 176..183

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    demoPool.data.forEach((e, i) => {
        if (i) {
            let space = document.createElement("span");
            space.innerHTML = " ";
            stList.appendChild(space);
Severity: Major
Found in src/demoTui/index.js and 1 other location - About 6 hrs to fix
oldsrc/cambiare_wa/index.js on lines 59..73

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    demoPool.data.forEach((e, i) => {
        if (i) {
            let space = document.createElement("span");
            space.innerHTML = " ";
            stList.appendChild(space);
Severity: Major
Found in oldsrc/cambiare_wa/index.js and 1 other location - About 6 hrs to fix
src/demoTui/index.js on lines 62..76

Identical blocks of code found in 3 locations. Consider refactoring.
Open

let getBlobFrom = async function (filename) {
    let i = 0;
    while (i < srcPaths.length) {
        let e = srcPaths[i];
        let response = await fetch(`${e}${filename}`);
Severity: Major
Found in src/cambiare_demo/index.js and 2 other locations - About 4 hrs to fix
oldsrc/cambiare_wa/index.js on lines 44..55
src/demoTui/index.js on lines 47..58

Identical blocks of code found in 3 locations. Consider refactoring.
Open

let getBlobFrom = async function (filename) {
    let i = 0;
    while (i < srcPaths.length) {
        let e = srcPaths[i];
        let response = await fetch(`${e}${filename}`);
Severity: Major
Found in oldsrc/cambiare_wa/index.js and 2 other locations - About 4 hrs to fix
src/cambiare_demo/index.js on lines 86..97
src/demoTui/index.js on lines 47..58

Identical blocks of code found in 3 locations. Consider refactoring.
Open

let getBlobFrom = async function (filename) {
    let i = 0;
    while (i < srcPaths.length) {
        let e = srcPaths[i];
        let response = await fetch(`${e}${filename}`);
Severity: Major
Found in src/demoTui/index.js and 2 other locations - About 4 hrs to fix
oldsrc/cambiare_wa/index.js on lines 44..55
src/cambiare_demo/index.js on lines 86..97

Function rawToPool has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

let rawToPool = function (midiJson) {
    //console.debug(midiJson);
    let list = new TimedEvents();
    let upThis = this;
    let timeDiv = midiJson.timeDivision,
Severity: Major
Found in src/basic/transform.js - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    $e("#openAudio").addEventListener("click", async function () {
        useMidiBus = false;
        midwIndicator.classList.off("active");
        if (audioBlob) {
            URL.revokeObjectURL(audioBlob);
    Severity: Major
    Found in oldsrc/cambiare_wa/index.js and 1 other location - About 2 hrs to fix
    src/demoTui/index.js on lines 159..167

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    $e("#openAudio").addEventListener("click", async function () {
        useMidiBus = false;
        midwIndicator.classList.off("active");
        if (audioBlob) {
            URL.revokeObjectURL(audioBlob);
    Severity: Major
    Found in src/demoTui/index.js and 1 other location - About 2 hrs to fix
    oldsrc/cambiare_wa/index.js on lines 143..151

    Function renderSect has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    let renderSect = function (data, offX, offY, boundX, boundY, pixelSize, isTwoByOne) {
        if (resourceViewer && data) {
            for (let i = 0; i < data.length; i ++) {
                let iX = i % data.width, iY = (i - iX) / data.width;
                if (iX < boundX && iY < boundY) {
    Severity: Minor
    Found in src/tsvView/index.js - About 2 hrs to fix

    Function sysexBitmap has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    let sysexBitmap = function (frameData, type = "xg", frameId = 0, noCopy) {
        if (!frameData?.length) {
            throw Error(`Blank frame data`);
        };
        // 0 for XG, 1 for GS, 2 for NS5R
    Severity: Major
    Found in src/state/emitGlobal.js - About 2 hrs to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          stDemo.to = function (i) {
              stDemo.forEach(function (e) {
                  e.classList.off("active");
              });
              if (i > -1) {
      Severity: Major
      Found in oldsrc/cambiare_wa/index.js and 3 other locations - About 2 hrs to fix
      oldsrc/cambiare_wa/index.js on lines 24..31
      src/demoTui/index.js on lines 22..29
      src/demoTui/index.js on lines 77..84

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      stSwitch.to = function (i) {
          stSwitch.forEach(function (e) {
              e.classList.off("active");
          });
          if (i > -1) {
      Severity: Major
      Found in oldsrc/cambiare_wa/index.js and 3 other locations - About 2 hrs to fix
      oldsrc/cambiare_wa/index.js on lines 74..81
      src/demoTui/index.js on lines 22..29
      src/demoTui/index.js on lines 77..84

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          stDemo.to = function (i) {
              stDemo.forEach(function (e) {
                  e.classList.off("active");
              });
              if (i > -1) {
      Severity: Major
      Found in src/demoTui/index.js and 3 other locations - About 2 hrs to fix
      oldsrc/cambiare_wa/index.js on lines 24..31
      oldsrc/cambiare_wa/index.js on lines 74..81
      src/demoTui/index.js on lines 22..29

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      stSwitch.to = function (i) {
          stSwitch.forEach(function (e) {
              e.classList.off("active");
          });
          if (i > -1) {
      Severity: Major
      Found in src/demoTui/index.js and 3 other locations - About 2 hrs to fix
      oldsrc/cambiare_wa/index.js on lines 24..31
      oldsrc/cambiare_wa/index.js on lines 74..81
      src/demoTui/index.js on lines 77..84

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if (voiceName) {
                                  voiceMap += `\n063    ${(entryWin[17] + 13).toString().padStart(3, "0")}    ${entryWin[19].toString().padStart(3, "0")}    ${voiceName}`;
                              };
      Severity: Major
      Found in src/state/bankDecoder.js and 1 other location - About 2 hrs to fix
      src/state/bankDecoder.js on lines 105..107

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              if (voiceName) {
                                  voiceMap += `\n063    ${(entryWin[17] + 1).toString().padStart(3, "0")}    ${entryWin[19].toString().padStart(3, "0")}    ${voiceName}`;
                              };
      Severity: Major
      Found in src/state/bankDecoder.js and 1 other location - About 2 hrs to fix
      src/state/bankDecoder.js on lines 73..75

      Function sysexBitmap has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      let sysexBitmap = function (frameData, type = "xg", frameId = 0, noCopy) {
          if (!frameData?.length) {
              throw Error(`Blank frame data`);
          };
          // 0 for XG, 1 for GS, 2 for NS5R
      Severity: Minor
      Found in src/state/emitGlobal.js - About 1 hr to fix

      Function arrowGen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      let arrowGen = function (charArr, value, border, unit) {
          let boundLow = border - (unit >> 1), boundHi = border + (unit >> 1);
          if (value > border) {
              for (let c = 0; value > border; c ++) {
                  charArr[c] = (value < boundHi) ? "=" : ">";
      Severity: Minor
      Found in src/disp/texted.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language