lucidlogic/omnipay-pesapal

View on GitHub
src/OAuth/OAuthRequest.php

Summary

Maintainability
A
0 mins
Test Coverage

Method from_request has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

    public static function from_request($http_method = null, $http_url = null, $parameters = null)
    {
        $scheme = (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != 'on')
            ? 'http'
            : 'https';
Severity: Minor
Found in src/OAuth/OAuthRequest.php - About 1 hr to fix

    Function from_request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Invalid

        public static function from_request($http_method = null, $http_url = null, $parameters = null)
        {
            $scheme = (!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] != 'on')
                ? 'http'
                : 'https';
    Severity: Minor
    Found in src/OAuth/OAuthRequest.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function to_header has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Invalid

        public function to_header()
        {
            $out = 'Authorization: OAuth realm=""';
            $total = [];
            foreach ($this->parameters as $k => $v) {
    Severity: Minor
    Found in src/OAuth/OAuthRequest.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status