Sign upLogin

lucliscio/fanKounter

View on GitHub
Star
src/libs/Browscap.php

Summary

Maintainability
F
1 wk
Test Coverage

File Browscap.php has 811 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace phpbrowscap;

/**
Severity: Major
Found in src/libs/Browscap.php - About 1 day to fix

    Function getBrowser has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getBrowser($user_agent = null, $return_array = false)
    {
        if ($this->shouldCacheBeUpdated()) {
            try {
                $this->updateCache();
    Severity: Minor
    Found in src/libs/Browscap.php - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method createCacheNewWay has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function createCacheNewWay($iniContent)
    {
        $patternPositions = array();

        // get all patterns from the ini file in the correct order,
    Severity: Major
    Found in src/libs/Browscap.php - About 4 hrs to fix

      Function createCacheNewWay has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function createCacheNewWay($iniContent)
    {
        $patternPositions = array();

        // get all patterns from the ini file in the correct order,
      Severity: Minor
      Found in src/libs/Browscap.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _getRemoteData has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _getRemoteData($url)
    {
        ini_set('user_agent', $this->_getUserAgent());

        switch ($this->_getUpdateMethod()) {
      Severity: Minor
      Found in src/libs/Browscap.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getBrowser has 87 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getBrowser($user_agent = null, $return_array = false)
    {
        if ($this->shouldCacheBeUpdated()) {
            try {
                $this->updateCache();
      Severity: Major
      Found in src/libs/Browscap.php - About 3 hrs to fix

        Browscap has 28 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Browscap
{
    /**
     * Current version of the class.
     */
        Severity: Minor
        Found in src/libs/Browscap.php - About 3 hrs to fix

          Method _getRemoteData has 82 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function _getRemoteData($url)
    {
        ini_set('user_agent', $this->_getUserAgent());

        switch ($this->_getUpdateMethod()) {
          Severity: Major
          Found in src/libs/Browscap.php - About 3 hrs to fix

            Function _getRemoteIniFile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function _getRemoteIniFile($url, $path)
    {
        // local and remote file are the same, no update possible
        if ($url == $path) {
            return false;
            Severity: Minor
            Found in src/libs/Browscap.php - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method createCacheOldWay has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function createCacheOldWay($iniContent, $actLikeNewVersion = false)
    {
        $browsers = parse_ini_string($iniContent, true, INI_SCANNER_RAW);

        if ($actLikeNewVersion) {
            Severity: Major
            Found in src/libs/Browscap.php - About 2 hrs to fix

              Function createCacheOldWay has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function createCacheOldWay($iniContent, $actLikeNewVersion = false)
    {
        $browsers = parse_ini_string($iniContent, true, INI_SCANNER_RAW);

        if ($actLikeNewVersion) {
              Severity: Minor
              Found in src/libs/Browscap.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method _getRemoteIniFile has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function _getRemoteIniFile($url, $path)
    {
        // local and remote file are the same, no update possible
        if ($url == $path) {
            return false;
              Severity: Minor
              Found in src/libs/Browscap.php - About 1 hr to fix

                Method updateCache has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function updateCache()
    {
        $lockfile = $this->cacheDir . 'cache.lock';

        $lockRes = fopen($lockfile, 'w+');
                Severity: Minor
                Found in src/libs/Browscap.php - About 1 hr to fix

                  Function _array2string has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function _array2string($array)
    {
        $content = "array(\n";

        foreach ($array as $key => $value) {
                  Severity: Minor
                  Found in src/libs/Browscap.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function clearProxySettings has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function clearProxySettings($wrapper = null)
    {
        $wrappers = isset($wrapper) ? array($wrapper) : array_keys($this->_streamContextOptions);

        $clearedWrappers = array();
                  Severity: Minor
                  Found in src/libs/Browscap.php - About 55 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                              while (!feof($remote_handler)) {
                                $file .= fgets($remote_handler);
                            }
                  Severity: Major
                  Found in src/libs/Browscap.php - About 45 mins to fix

                    Function shouldCacheBeUpdated has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function shouldCacheBeUpdated()
    {
        // Load the cache at the first request
        if ($this->_cacheLoaded) {
            return false;
                    Severity: Minor
                    Found in src/libs/Browscap.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _getUpdateMethod has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function _getUpdateMethod()
    {
        // Caches the result
        if ($this->updateMethod === null) {
            if ($this->localFile !== null) {
                    Severity: Minor
                    Found in src/libs/Browscap.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method addProxySettings has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function addProxySettings($server, $port = 3128, $wrapper = 'http', $username = null, $password = null)
                    Severity: Minor
                    Found in src/libs/Browscap.php - About 35 mins to fix

                      Function updateCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function updateCache()
    {
        $lockfile = $this->cacheDir . 'cache.lock';

        $lockRes = fopen($lockfile, 'w+');
                      Severity: Minor
                      Found in src/libs/Browscap.php - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                              return 0;
                      Severity: Major
                      Found in src/libs/Browscap.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return '';
                        Severity: Major
                        Found in src/libs/Browscap.php - About 30 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          if (!$countMatches) {
                    $tmpPatterns[$pattern] = $i;
                } else {
                    $compressedPattern = preg_replace(
                        self::REGEX_DELIMITER . '\d' . self::REGEX_DELIMITER,
                          Severity: Major
                          Found in src/libs/Browscap.php and 1 other location - About 1 hr to fix
                          src/libs/Browscap.php on lines 784..798

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 104.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          if (!$countMatches) {
                    $tmpPatterns[$pattern] = $i;
                } else {
                    $compressedPattern = preg_replace(
                        self::REGEX_DELIMITER . '\d' . self::REGEX_DELIMITER,
                          Severity: Major
                          Found in src/libs/Browscap.php and 1 other location - About 1 hr to fix
                          src/libs/Browscap.php on lines 669..683

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 104.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status