ludoviclefevre/hexo-generator-seo-friendly-sitemap

View on GitHub

Showing 11 of 11 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const tag = function(locals, config) {
  const get = function() {
    if (config.sitemap && config.sitemap.tag === false) {
      return
    }
Severity: Major
Found in lib/tag.js and 1 other location - About 1 day to fix
lib/category.js on lines 8..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 219.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const category = function(locals, config) {
  const get = function() {
    if (config.sitemap && config.sitemap.category === false) {
      return
    }
Severity: Major
Found in lib/category.js and 1 other location - About 1 day to fix
lib/tag.js on lines 8..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 219.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function post has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const post = function(locals, config) {
  const get = function() {
    if (locals.posts.length === 0) {
      return
    }
Severity: Minor
Found in lib/post.js - About 1 hr to fix

    Function get has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const get = function() {
        if (locals.posts.length === 0) {
          return
        }
        const posts = _(locals.posts.toArray())
    Severity: Minor
    Found in lib/post.js - About 1 hr to fix

      Function page has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const page = function(locals, config) {
        const isExcluded = function(page) {
          if (page.sitemap === false) {
            return true
          }
      Severity: Minor
      Found in lib/page.js - About 1 hr to fix

        Function seoFriendlySitemap has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const seoFriendlySitemap = function(locals) {
          const config = this.config,
            posts = require('./post')(locals, config),
            pages = require('./page')(locals, config),
            categories = require('./category')(locals, config),
        Severity: Minor
        Found in lib/generator.js - About 1 hr to fix

          Function tag has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const tag = function(locals, config) {
            const get = function() {
              if (config.sitemap && config.sitemap.tag === false) {
                return
              }
          Severity: Minor
          Found in lib/tag.js - About 1 hr to fix

            Function category has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const category = function(locals, config) {
              const get = function() {
                if (config.sitemap && config.sitemap.category === false) {
                  return
                }
            Severity: Minor
            Found in lib/category.js - About 1 hr to fix

              Function page has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              const page = function(locals, config) {
                const isExcluded = function(page) {
                  if (page.sitemap === false) {
                    return true
                  }
              Severity: Minor
              Found in lib/page.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  const pages = _(locals.pages.toArray())
                    .reject(isExcluded)
                    .orderBy('updated', 'desc')
                    .value()
              Severity: Minor
              Found in lib/page.js and 1 other location - About 35 mins to fix
              lib/post.js on lines 13..16

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  const posts = _(locals.posts.toArray())
                    .filter(postInSitemap)
                    .orderBy('updated', 'desc')
                    .value()
              Severity: Minor
              Found in lib/post.js and 1 other location - About 35 mins to fix
              lib/page.js on lines 18..21

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language