Sign upLogin

lugu/qiloop

View on GitHub
Star
meta/idl/parser.go

Summary

Maintainability
D
1 day
Test Coverage
B
83%

File parser.go has 758 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package idl

import (
    "fmt"
    "io"
Severity: Major
Found in meta/idl/parser.go - About 1 day to fix

    Function ParsePackage has 5 return statements (exceeds 4 allowed).
    Open

    func ParsePackage(input []byte) (*PackageDeclaration, error) {
    context := NewContext()
    parser := packageParser(context)
    root, scanner := parser(parsec.NewScanner(input).TrackLineno())
    _, scanner = scanner.SkipWS()
    Severity: Major
    Found in meta/idl/parser.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func nodifySignal(nodes []signature.Node) signature.Node {
    if ok, err := checkError(nodes); ok {
        return fmt.Errorf("parse method: %s", err)
    }
    paramNode := nodes[3]
      Severity: Major
      Found in meta/idl/parser.go and 1 other location - About 2 hrs to fix
      meta/idl/parser.go on lines 731..749

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 200.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func nodifyProperty(nodes []signature.Node) signature.Node {
    if ok, err := checkError(nodes); ok {
        return fmt.Errorf("parse method: %s", err)
    }
    paramNode := nodes[3]
      Severity: Major
      Found in meta/idl/parser.go and 1 other location - About 2 hrs to fix
      meta/idl/parser.go on lines 710..728

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 200.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
      Open

          } else {
      Severity: Minor
      Found in meta/idl/parser.go by golint

      There are no issues that match your filters.

      Category
      Status