Sign upLogin

lugu/qiloop

View on GitHub
Star
meta/idl/proxy.go

Summary

Maintainability
D
1 day
Test Coverage
B
81%

File proxy.go has 586 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package idl

import (
    "fmt"
Severity: Minor
Found in meta/idl/proxy.go - About 4 hrs to fix

    Function generateObjectInterface has 86 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func generateObjectInterface(itf *InterfaceType, serviceName string,
    file *jen.File) error {

    definitions := make([]jen.Code, 0)
    Severity: Major
    Found in meta/idl/proxy.go - About 2 hrs to fix

      Function generateProxyType has 79 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func generateProxyType(file *jen.File, serviceName, ProxyName string,
    itf *InterfaceType) {

    file.Comment(ProxyName + " implements " + objName(serviceName))
    if ProxyName == proxyName("Object") || ProxyName == proxyName("ServiceZero") {
      Severity: Major
      Found in meta/idl/proxy.go - About 2 hrs to fix

        Function methodBodyBlock2 has 71 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func methodBodyBlock2(method Method, params *signature.TupleType,
    ret signature.Type) (*Statement, error) {
    writing := []jen.Code{}
    if ret.Signature() == "v" {
        writing = append(writing, jen.Var().Id("ret").Struct())
        Severity: Minor
        Found in meta/idl/proxy.go - About 1 hr to fix

          Function generateObjectInterface has 11 return statements (exceeds 4 allowed).
          Open

          func generateObjectInterface(itf *InterfaceType, serviceName string,
    file *jen.File) error {

    definitions := make([]jen.Code, 0)
          Severity: Major
          Found in meta/idl/proxy.go - About 1 hr to fix

            Function generateProxyObject has 8 return statements (exceeds 4 allowed).
            Open

            func generateProxyObject(itf *InterfaceType, serviceName string,
    file *jen.File) error {

    proxyName := proxyName(serviceName)
    generateProxyType(file, serviceName, proxyName, itf)
            Severity: Major
            Found in meta/idl/proxy.go - About 50 mins to fix

              Function generatePropertyDef has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func generatePropertyDef(file *jen.File, serviceName string,
    property Property, getMethodName, setMethodName,
    subscribeMethodName string, definitions *[]jen.Code) error {
              Severity: Minor
              Found in meta/idl/proxy.go - About 35 mins to fix

                Function generateMethodDef has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func generateMethodDef(file *jen.File, serviceName string,
    method Method, methodName string, definitions *[]jen.Code) error {
                Severity: Minor
                Found in meta/idl/proxy.go - About 35 mins to fix

                  Function generateSignalDef has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func generateSignalDef(file *jen.File, serviceName string,
    signal Signal, signalName string, definitions *[]jen.Code) error {
                  Severity: Minor
                  Found in meta/idl/proxy.go - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            if ret.Signature() != "v" {
            writing = append(writing, jen.If(jen.Err().Op("=").Add(v.Type.Marshal(v.Name, "&buf")).Op(";").Err().Op("!=").Nil()).Block(
                jen.Id(`return ret, fmt.Errorf("serialize `+v.Name+`: %s", err)`),
            ))
        } else {
                    Severity: Minor
                    Found in meta/idl/proxy.go and 1 other location - About 45 mins to fix
                    meta/idl/proxy.go on lines 554..558

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 115.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            } else {
            writing = append(writing, jen.If(jen.Err().Op("=").Add(v.Type.Marshal(v.Name, "&buf")).Op(";").Err().Op("!=").Nil()).Block(
                jen.Id(`return fmt.Errorf("serialize `+v.Name+`: %s", err)`),
            ))
        }
                    Severity: Minor
                    Found in meta/idl/proxy.go and 1 other location - About 45 mins to fix
                    meta/idl/proxy.go on lines 550..554

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 115.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status