lugu/qiloop

Avoid deeply nested control flow statements.

Open

            if err == nil {
                err = fmt.Errorf("no progress")
            }

Avoid deeply nested control flow statements.

Open

            if err == nil {
                err = fmt.Errorf("no progress")
            }

Function WriteString has 5 return statements (exceeds 4 allowed).

Open

func WriteString(s string, w io.Writer) error {
    data := []byte(s)
    size := len(data)
    if size > int(MaxStringSize) {
        return fmt.Errorf("invalid string size: %d", size)

Function ReadString has 5 return statements (exceeds 4 allowed).

Open

func ReadString(r io.Reader) (string, error) {
    size, err := ReadUint32(r)
    if err != nil {
        return "", fmt.Errorf("read string size: %s", err)
    }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func ReadN(r io.Reader, buf []byte, length int) error {
    size := 0
    for size < length {
        read, err := r.Read(buf[size:])
        size += read

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

func WriteN(w io.Writer, buf []byte, length int) error {
    size := 0
    for size < length {
        write, err := w.Write(buf[size:])
        size += write

• Read up
  Read up