Sign upLogin

lujanfernaud/prevy

View on GitHub
Star
app/controllers/groups/invited_members_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Groups::InvitedMembersController has no descriptive comment
Open

class Groups::InvitedMembersController < ApplicationController
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

Inconsistent indentation detected.
Open

    def user
      @_user ||= User.find_by(email: invitation.email)
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def create_membership_and_destroy_invitation
      invitation.group.members << registered_user
      invitation.destroy
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def invited_user_params
      {
        confirmation_token: invitation.token,
        group_id:           invitation.group.id,
        invited:            true
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

class Groups::InvitedMembersController < ApplicationController
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use nested module/class definitions instead of compact style.
Open

class Groups::InvitedMembersController < ApplicationController
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Inconsistent indentation detected.
Open

    def create_user_and_membership
      return if user_was_created_but_not_confirmed?

      GroupInvitedMember.create_from invitation
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def registered_user
      @_registered_user ||= invitation.user
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def invitation
      @_invitation ||= GroupInvitation.find_by(token: params[:token])
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def destroy_user_sample_content
      UserSampleContentDestroyer.call(registered_user)
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def user_was_created_but_not_confirmed?
      user && !user.confirmed?
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

There are no issues that match your filters.

Category
Status