Sign upLogin

lujanfernaud/prevy

View on GitHub
Star
app/models/topic.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Class Topic has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class Topic < ApplicationRecord
  PRIORITY            = 0
  MINIMUM_BODY_LENGTH = 20
  EDITED_OFFSET_TIME  = 600 # 10 minutes
  POINTS              = 3
Severity: Minor
Found in app/models/topic.rb - About 2 hrs to fix

    Topic has at least 21 methods
    Open

    class Topic < ApplicationRecord
    Severity: Minor
    Found in app/models/topic.rb by reek

    Too Many Methods is a special case of LargeClass.

    Example

    Given this configuration

    TooManyMethods:
  max_methods: 3

    and this code:

    class TooManyMethods
  def one; end
  def two; end
  def three; end
  def four; end
end

    Reek would emit the following warning:

    test.rb -- 1 warning:
  [1]:TooManyMethods has at least 4 methods (TooManyMethods)

    Inconsistent indentation detected.
    Open

        def set_default_edited_by
      self.edited_by = user
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Inconsistent indentation detected.
    Open

        def user_group_points
      UserGroupPoints.find_or_create_by!(user: user, group: group)
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Inconsistent indentation detected.
    Open

        def topic_type_priority
      Object.const_get(type)::PRIORITY
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Inconsistent indentation detected.
    Open

        def set_priority
      self.priority = topic_type_priority
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Inconsistent indentation detected.
    Open

        def body_length
      BodyLengthValidator.call(self, length: MINIMUM_BODY_LENGTH)
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Use the lambda method for multiline lambdas.
    Open

      scope :special, -> {
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cop (by default) checks for uses of the lambda literal syntax for single line lambdas, and the method call syntax for multiline lambdas. It is configurable to enforce one of the styles for both single line and multiline lambdas as well.

    Example: EnforcedStyle: linecountdependent (default)

    # bad
f = lambda { |x| x }
f = ->(x) do
      x
    end

# good
f = ->(x) { x }
f = lambda do |x|
      x
    end

    Example: EnforcedStyle: lambda

    # bad
f = ->(x) { x }
f = ->(x) do
      x
    end

# good
f = lambda { |x| x }
f = lambda do |x|
      x
    end

    Example: EnforcedStyle: literal

    # bad
f = lambda { |x| x }
f = lambda do |x|
      x
    end

# good
f = ->(x) { x }
f = ->(x) do
      x
    end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        where.not(type: "Topic")
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Missing top-level class documentation comment.
    Open

    class Topic < ApplicationRecord
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

    Use the lambda method for multiline lambdas.
    Open

      scope :normal, -> {
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cop (by default) checks for uses of the lambda literal syntax for single line lambdas, and the method call syntax for multiline lambdas. It is configurable to enforce one of the styles for both single line and multiline lambdas as well.

    Example: EnforcedStyle: linecountdependent (default)

    # bad
f = lambda { |x| x }
f = ->(x) do
      x
    end

# good
f = ->(x) { x }
f = lambda do |x|
      x
    end

    Example: EnforcedStyle: lambda

    # bad
f = ->(x) { x }
f = ->(x) do
      x
    end

# good
f = lambda { |x| x }
f = lambda do |x|
      x
    end

    Example: EnforcedStyle: literal

    # bad
f = lambda { |x| x }
f = lambda do |x|
      x
    end

# good
f = ->(x) { x }
f = ->(x) do
      x
    end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        type.gsub("Topic", "")
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        type.gsub("Topic", "")
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Inconsistent indentation detected.
    Open

        def should_generate_new_friendly_id?
      slug.blank? || saved_change_to_title?
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        type == "Topic"
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Inconsistent indentation detected.
    Open

        def set_edited_at
      return unless content_changed?

      self.edited_at = Time.current
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Inconsistent indentation detected.
    Open

        def set_default_last_commented_at
      self.last_commented_at = Time.current
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Inconsistent indentation detected.
    Open

        def user_id
      user.id
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        where(type: "Topic")
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        type == "PinnedTopic"
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        return if type == "Topic"
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Inconsistent indentation detected.
    Open

        def group_id
      group.id
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

        type == "AnnouncementTopic"
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Prefer single-quoted strings when you don't need string interpolation or special symbols.
    Open

      belongs_to :edited_by, class_name: "User", optional: true
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    Checks if uses of quotes match the configured preference.

    Example: EnforcedStyle: single_quotes (default)

    # bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

    Example: EnforcedStyle: double_quotes

    # bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

    Inconsistent indentation detected.
    Open

        def content_changed?
      title_changed? || body_changed?
    end
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Use the lambda method for multiline lambdas.
    Open

      scope :prioritized, -> {
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cop (by default) checks for uses of the lambda literal syntax for single line lambdas, and the method call syntax for multiline lambdas. It is configurable to enforce one of the styles for both single line and multiline lambdas as well.

    Example: EnforcedStyle: linecountdependent (default)

    # bad
f = lambda { |x| x }
f = ->(x) do
      x
    end

# good
f = ->(x) { x }
f = lambda do |x|
      x
    end

    Example: EnforcedStyle: lambda

    # bad
f = ->(x) { x }
f = ->(x) do
      x
    end

# good
f = lambda { |x| x }
f = lambda do |x|
      x
    end

    Example: EnforcedStyle: literal

    # bad
f = lambda { |x| x }
f = lambda do |x|
      x
    end

# good
f = ->(x) { x }
f = ->(x) do
      x
    end

    Use %i or %I for an array of symbols.
    Open

            [:title, :group_id],
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cop can check for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    Inconsistent indentation detected.
    Open

        def slug_candidates
      [
        :title,
        [:title, :group_id],
        [:title, :group_id, :user_id]
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cops checks for inconsistent indentation.

    Example:

    class A
  def test
    puts 'hello'
     puts 'world'
  end
end

    Use %i or %I for an array of symbols.
    Open

            [:title, :group_id, :user_id]
    Severity: Minor
    Found in app/models/topic.rb by rubocop

    This cop can check for array literals made up of symbols that are not using the %i() syntax.

    Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

    Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

    Example: EnforcedStyle: percent (default)

    # good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

    Example: EnforcedStyle: brackets

    # good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

    There are no issues that match your filters.

    Category
    Status