lujanfernaud/prevy

View on GitHub
app/queries/recent_members_query.rb

Summary

Maintainability
A
0 mins
Test Coverage

RecentMembersQuery has no descriptive comment
Open

class RecentMembersQuery
Severity: Minor
Found in app/queries/recent_members_query.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

Inconsistent indentation detected.
Open

    def set_user_ids
      @user_ids = memberships_by_creation_date.map(&:user_id)
    end
Severity: Minor
Found in app/queries/recent_members_query.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

class RecentMembersQuery
Severity: Minor
Found in app/queries/recent_members_query.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def set_members
      @members = group.members.confirmed.where(id: user_ids)
    end
Severity: Minor
Found in app/queries/recent_members_query.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def memberships_by_creation_date
      GroupMembership.confirmed(group).by_creation_date(group).limit(limit)
    end
Severity: Minor
Found in app/queries/recent_members_query.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    attr_reader :group, :limit, :user_ids, :members
Severity: Minor
Found in app/queries/recent_members_query.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def sort_members
      members.index_by(&:id).values_at(*user_ids)
    end
Severity: Minor
Found in app/queries/recent_members_query.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

There are no issues that match your filters.

Category
Status