Sign upLogin

lujanfernaud/prevy

View on GitHub
Star
app/services/sample_group_creator.rb

Summary

Maintainability
A
0 mins
Test Coverage

SampleGroupCreator has at least 6 instance variables
Open

class SampleGroupCreator
Severity: Minor
Found in app/services/sample_group_creator.rb by reek

Too Many Instance Variables is a special case of LargeClass.

Example

Given this configuration

TooManyInstanceVariables:
  max_instance_variables: 3

and this code:

class TooManyInstanceVariables
  def initialize
    @arg_1 = :dummy
    @arg_2 = :dummy
    @arg_3 = :dummy
    @arg_4 = :dummy
  end
end

Reek would emit the following warning:

test.rb -- 5 warnings:
  [1]:TooManyInstanceVariables has at least 4 instance variables (TooManyInstanceVariables)

SampleGroupCreator#add_sample_members has approx 6 statements
Open

    def add_sample_members
Severity: Minor
Found in app/services/sample_group_creator.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

SampleGroupCreator#group_name doesn't depend on instance state (maybe move it to another class?)
Open

    def group_name
Severity: Minor
Found in app/services/sample_group_creator.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

SampleGroupCreator#group_location doesn't depend on instance state (maybe move it to another class?)
Open

    def group_location
Severity: Minor
Found in app/services/sample_group_creator.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

Inconsistent indentation detected.
Open

    def group_description
      I18n.t("sample_group.description", user_name: user.name)
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def group_name
      I18n.t("sample_group.name")
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    attr_reader :user, :group, :sample_users
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def build_roles
      sample_users.each do |user|
        @roles << user.roles.new(resource: group, name: "member")
      end
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def group_location
      I18n.t("sample_group.location")
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def add_sample_members
      build_memberships
      build_roles
      build_user_roles
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def update_members_count
      Group.reset_counters(group.id, :members)
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      I18n.t("sample_group.description", user_name: user.name)
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def build_memberships
      sample_users.each do |user|
        @memberships << GroupMembership.new(group: group, user: user)
      end
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def add_sample_organizers
      group.add_to_organizers(SampleUser.prevy_bot)

      SampleUser.select_random_users(RANDOM_ORGANIZERS).each do |member|
        group.add_to_organizers(member)
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      I18n.t("sample_group.location")
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        @roles << user.roles.new(resource: group, name: "member")
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def build_user_roles
      @roles.each.with_index do |role, index|
        @user_roles << UserRole.new(role: role, user: sample_users[index])
      end
    end
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      I18n.t("sample_group.name")
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def create_group
      @group = user.owned_groups.build(
        name:         group_name,
        description:  group_description,
        location:     group_location,
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

There are no issues that match your filters.

Category
Status