Sign upLogin

lujanfernaud/prevy

View on GitHub
Star

Showing 1,727 of 1,727 total issues

Inconsistent indentation detected.
Open

    def find_comments
      @topic.comments.includes(:edited_by)
    end
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def topic_params
      params.require(:topic)
            .permit(:title, :body, :type)
            .merge(edited_by: current_user)
    end
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def add_breadcrumbs_for_creation
      add_breadcrumb @group.name,   group_path(@group)
      add_breadcrumb "Invitations", group_invitations_path(@group)
      add_breadcrumb "Invite someone"
    end
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      add_breadcrumb "Invitations", group_invitations_path(@group)
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      add_breadcrumb "Invite someone"
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def user
      @_user ||= User.find_by(email: invitation.email)
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def find_role
      params[:role]
    end
Severity: Minor
Found in app/controllers/groups/roles_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def notify_user_with_new_role
      return if @group.sample_group?

      NewGroupRoleNotifier.call(user: @user, group: @group, role: @role)
    end
Severity: Minor
Found in app/controllers/groups/roles_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def redirect_back_with_anchor_link
      if params[:origin] == "events"
        redirect_to group_event_path(@group, @topic.event) + comment_css_id
      else
        redirect_to group_topic_path(@group, @topic) + comment_css_id
Severity: Minor
Found in app/controllers/groups/topics/comments_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def notify_user_accepted
      return if @group.sample_group?

      NewGroupMembershipNotifier.call(@membership)
    end
Severity: Minor
Found in app/controllers/groups/memberships_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use the return of the conditional for variable assignment and comparison.
Open

      if @topic.announcement?
        flash[:success] = "New announcement topic created."
      elsif @topic.pinned?
        flash[:success] = "New pinned topic created."
      else
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

    flash[:success] = "Topic deleted."
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      return unless @topic.saved_changes.include?("type")
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use %i or %I for an array of symbols.
Open

  after_action  :verify_authorized, except: [:index, :show]
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

Use nested module/class definitions instead of compact style.
Open

class Groups::InvitationsController < ApplicationController
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Inconsistent indentation detected.
Open

    def create_membership_and_destroy_invitation
      invitation.group.members << registered_user
      invitation.destroy
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def flash_save
      if @topic.announcement?
        flash[:success] = "New announcement topic created."
      elsif @topic.pinned?
        flash[:success] = "New pinned topic created."
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def flash_update
      if set_to_normal_topic?
        flash[:success] = "Topic set to normal topic."
      elsif set_to_pinned_topic?
        flash[:success] = "Topic set to pinned topic."
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use nested module/class definitions instead of compact style.
Open

class Groups::TopicsController < ApplicationController
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      add_breadcrumb "New topic"
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"
Severity
Category
Status
Source
Language