Sign upLogin

lujanfernaud/prevy

View on GitHub
Star

Showing 1,727 of 1,727 total issues

Inconsistent indentation detected.
Open

    def create_comment
      TopicComment.new(
        comment_params.merge(topic: @topic, user: current_user)
      )
    end
Severity: Minor
Found in app/controllers/groups/topics/comments_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def destroy_user_sample_content
      UserSampleContentDestroyer.call(@user)
    end
Severity: Minor
Found in app/controllers/groups/memberships_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def add_breadcrumbs_for_show
      add_breadcrumb @group.name, group_path(@group)
      add_breadcrumb "Topics", group_topics_path(@group)
      add_breadcrumb @topic.title
    end
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def invitation_params
      params.require(:group_invitation)
            .permit(:name, :email)
            .merge(group: find_group, sender: current_user)
    end
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

class Groups::MembersController < ApplicationController
Severity: Minor
Found in app/controllers/groups/members_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def remove_role_from_user
      GroupRoleRemover.call(@group, @user, @role)
    end
Severity: Minor
Found in app/controllers/groups/roles_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def comment_css_id
      comment = @comment.persisted? ? @comment : @topic.comments.last

      PreviousCommentCSSIdLocator.call(comment, @topic)
    end
Severity: Minor
Found in app/controllers/groups/topics/comments_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      add_breadcrumb "Edit comment"
Severity: Minor
Found in app/controllers/groups/topics/comments_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def flash_deletion_message_to_group_owner
      flash[:success] = "#{@user.name} has been removed " \
                        "as a member of '#{@group.name}'."
    end
Severity: Minor
Found in app/controllers/groups/memberships_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use nested module/class definitions instead of compact style.
Open

class Groups::MembershipsController < ApplicationController
Severity: Minor
Found in app/controllers/groups/memberships_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Missing top-level class documentation comment.
Open

class Groups::MembershipsController < ApplicationController
Severity: Minor
Found in app/controllers/groups/memberships_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def find_topic
      Topic.find(params[:id])
    end
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def create_topic
      @group.topics.new(topic_params_with_user)
    end
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def add_breadcrumbs_for_topic_creation
      add_breadcrumb @group.name, group_path(@group)
      add_breadcrumb "Topics", group_topics_path(@group)
      add_breadcrumb "New topic"
    end
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Use the return of the conditional for variable assignment and comparison.
Open

      if set_to_normal_topic?
        flash[:success] = "Topic set to normal topic."
      elsif set_to_pinned_topic?
        flash[:success] = "Topic set to pinned topic."
      else
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      add_breadcrumb "Invitations"
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use nested module/class definitions instead of compact style.
Open

class Users::RegistrationsController < Devise::RegistrationsController
Severity: Minor
Found in app/controllers/users/registrations_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

    if resource.confirmed?
Severity: Minor
Found in app/controllers/users/confirmations_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      add_breadcrumb "Attendees", event_attendees_path(@event)
Severity: Minor
Found in app/controllers/events/attendees_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def is_sample_group_owner?
      group.owner == user
    end
Severity: Minor
Found in app/policies/attendance_policy.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end
Severity
Category
Status
Source
Language