Sign upLogin

lujanfernaud/prevy

View on GitHub
Star

Showing 1,727 of 1,727 total issues

Inconsistent indentation detected.
Open

    attr_reader :user, :invitation
Severity: Minor
Found in app/services/invitation_authorizer.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def add_sample_members
      build_memberships
      build_roles
      build_user_roles
Severity: Minor
Found in app/services/sample_group_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def flash_deletion_message_to_requester
      flash[:success] = "Your membership request has been deleted."
    end
Severity: Minor
Found in app/controllers/groups/membership_requests_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def notify_requester
      return if @group.sample_group?

      DeclinedMembershipRequestNotifier.call(@membership_request)
    end
Severity: Minor
Found in app/controllers/groups/membership_requests_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def flash_deletion_message_to_group_owner
      flash[:success] = "The membership request has been deleted."
    end
Severity: Minor
Found in app/controllers/groups/membership_requests_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

class Groups::MembershipRequestsController < ApplicationController
Severity: Minor
Found in app/controllers/groups/membership_requests_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def topic_path
      if @topic.event?
        group_event_path(@group, @topic.event)
      else
        group_topic_path(@group, @topic)
Severity: Minor
Found in app/controllers/groups/topics/comments_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      render "groups/topics/show"
Severity: Minor
Found in app/controllers/groups/topics/comments_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def notify_user_deleted
      return if @group.sample_group?

      DeletedGroupMembershipNotifier.call(@membership)
    end
Severity: Minor
Found in app/controllers/groups/memberships_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        flash[:success] = "New announcement topic created."
Severity: Minor
Found in app/controllers/groups/topics_controller.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing top-level class documentation comment.
Open

class Groups::InvitationsController < ApplicationController
Severity: Minor
Found in app/controllers/groups/invitations_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use nested module/class definitions instead of compact style.
Open

class Users::NotificationsController < ApplicationController
Severity: Minor
Found in app/controllers/users/notifications_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Inconsistent indentation detected.
Open

    def find_group
      @group = Group.find(params[:group_id])
    end
Severity: Minor
Found in app/controllers/groups/membership_requests_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

class Users::NotificationsController < ApplicationController
Severity: Minor
Found in app/controllers/users/notifications_controller.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def flash_creation_message_to_requester
      flash[:success] = "Your request has been sent. " \
                        "You'll be notified when there's any change."
    end
Severity: Minor
Found in app/controllers/groups/membership_requests_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def attributes_update_and_password_matches?
      resource_update_attributes? && resource.password_match?
    end
Severity: Minor
Found in app/controllers/users/confirmations_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def invitation
      @_invitation ||= GroupInvitation.find_by(token: params[:token])
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def confirm_resource
      self.resource = resource_class.confirm_by_token(@confirmation_token)
      set_flash_message :notice, :confirmed unless user_invited?
    end
Severity: Minor
Found in app/controllers/users/confirmations_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def destroy_user_sample_content
      UserSampleContentDestroyer.call(registered_user)
    end
Severity: Minor
Found in app/controllers/groups/invited_members_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def find_event
      @event ||= EventDecorator.new(Event.find(params[:event_id]))
    end
Severity: Minor
Found in app/controllers/events/attendees_controller.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end
Severity
Category
Status
Source
Language