Sign upLogin

lujanfernaud/prevy

View on GitHub
Star

Showing 1,727 of 1,727 total issues

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  COMMENT_SEEDS  = YAML.load_file("db/seeds/event_comment_seeds.yml").shuffle
Severity: Minor
Found in app/services/sample_event_comments_creator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def new_invitation
      date       = CREATION_DATE + rand(ONE_MINUTE..TWENTY_THREE_HOURS)
      first_name = Faker::Name.first_name
      last_name  = Faker::Name.last_name
      full_name  = "#{first_name} #{last_name}"
Severity: Minor
Found in app/services/sample_invitation_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def create_membership_request
      @membership_request = MembershipRequest.create(
        user:    sample_user,
        group:   group,
        message: I18n.t("sample_membership_request.message")
Severity: Minor
Found in app/services/sample_membership_request_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def previous_comment_css_id
      "#comment-#{previous_comment.id}"
    end
Severity: Minor
Found in app/services/previous_comment_css_id_locator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def previous_comment
      comment_index = topic_comments.find_index(comment)

      topic_comments[comment_index - 1]
    end
Severity: Minor
Found in app/services/previous_comment_css_id_locator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def body_is_long_enough?
      body_without_leading_and_trailing_spaces.length > length
    end
Severity: Minor
Found in app/services/body_length_validator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def create_sample_invitations
      SampleInvitationCreator.call(group, quantity: 3)
    end
Severity: Minor
Found in app/services/user_sample_content_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def send_email_to(member)
      NotificationMailer.new_announcement_topic(
        member,
        announcement_topic
      ).deliver_later
Severity: Minor
Found in app/services/notifiers/new_announcement_notifier.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Missing top-level class documentation comment.
Open

class DeclinedMembershipRequestNotifier
Severity: Minor
Found in app/services/notifiers/membership_requests/declined_membership_request_notifier.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Inconsistent indentation detected.
Open

    def last_comment_date(topic)
      topic.comments.last.created_at
    end
Severity: Minor
Found in app/services/sample_comments_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  SPECIAL_ROLES = ["organizer", "moderator"].freeze
Severity: Minor
Found in app/services/group_role_remover.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/services/body_length_validator.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Inconsistent indentation detected.
Open

    attr_reader :record, :body, :length, :parser
Severity: Minor
Found in app/services/body_length_validator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      parsed_body.gsub(LEADING_SPACES, "").gsub(TRAILING_SPACES, "")
Severity: Minor
Found in app/services/body_length_validator.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Inconsistent indentation detected.
Open

    def create_image_placeholder
      generate_lqip
      convert_to_base64
      store_base64_image
    end
Severity: Minor
Found in app/services/image_placeholder_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def convert_to_base64
      @image_base64 = image_converter.call image_location
    end
Severity: Minor
Found in app/services/image_placeholder_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def build_topics_from_topic_seeds
      TOPIC_SEEDS.each do |seed|
        @topics << new_topic_from(seed)
      end
    end
Severity: Minor
Found in app/services/sample_topic_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def create_sample_event
      SampleEventCreator.call(group)
    end
Severity: Minor
Found in app/services/user_sample_content_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def new_comment_with(seed)
      attendee = attendees.pop
      created_at_date = CREATION_DATE + rand(ONE_MINUTE..TWENTY_THREE_HOURS)

      event_topic.comments.new(
Severity: Minor
Found in app/services/sample_event_comments_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end

Inconsistent indentation detected.
Open

    def run_comments_before_create_callbacks
      @comments.each do |comment|
        comment.run_callbacks(:create) { false }
      end
    end
Severity: Minor
Found in app/services/sample_event_comments_creator.rb by rubocop

This cops checks for inconsistent indentation.

Example:

class A
  def test
    puts 'hello'
     puts 'world'
  end
end
Severity
Category
Status
Source
Language