lujanfernaud/prevy

View on GitHub

Showing 1,727 of 1,727 total issues

Prefer single quoted strings
Open

@import "sections/notifications";

Prefer single quoted strings
Open

@import "vendor-modifications/octicons";

Properties should be ordered border-radius, box-shadow, font-size, margin, max-width, position
Open

  position: relative;

Color #E5C30F should be written as #e5c30f
Open

  background: #E5C30F;

Properties should be ordered background-color, border-radius, flex, padding-bottom, padding-top
Open

  flex: 0 !important;

!important should not be used
Open

    border-top-right-radius: $box-radius !important;

Selector event-box-big__text should be written in lowercase with hyphens
Open

.event-box-big__text,

Shorthand form for property padding should be written more concisely as .65rem .7rem .5rem instead of .65rem .7rem .5rem .7rem
Open

  padding: .65rem .7rem .5rem .7rem;

Properties should be ordered padding-bottom, padding-top
Open

  padding-top: 3.8rem;

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      field_name.remove("updated").gsub("_", " ")

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Missing magic comment # frozen_string_literal: true.
Open

#!/usr/bin/env ruby
Severity: Minor
Found in bin/update by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Use the new Ruby 1.9 hash syntax.
Open

  gem 'rails-erd',                     :require => false
Severity: Minor
Found in Gemfile by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

!important should not be used
Open

  margin-top: 2rem !important;

!important should not be used
Open

  border-top-left-radius: $box-radius !important;

Properties should be ordered border-radius, padding-bottom
Open

  padding-bottom: 100%;

Prefer single quoted strings
Open

@import "abstracts/helpers";

Prefer single quoted strings
Open

@import "components/spinner";

Prefer single quoted strings
Open

@import "sections/user-profile";

Color white should be written in hexadecimal form as #ffffff
Open

  color: white;

Properties should be ordered display, float, line-height, position, top, white-space
Open

  position: relative;
Severity
Category
Status
Source
Language