Sign upLogin

lukepolo/laracart

View on GitHub
Star

Showing 23 of 23 total issues

Function taxSummary has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    public function taxSummary()
    {
        $taxed = [];
        // tax item by item
        for ($qty = 0; $qty < $this->qty; $qty++) {
Severity: Minor
Found in src/CartItem.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File LaraCart.php has 489 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace LukePOLO\LaraCart;

use Illuminate\Auth\AuthManager;
Severity: Minor
Found in src/LaraCart.php - About 7 hrs to fix

    LaraCart has 48 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class LaraCart implements LaraCartContract
{
    const SERVICE = 'laracart';
    const HASH = LaraCartHasher::class;
    const RANHASH = 'generateRandomCartItemHash';
    Severity: Minor
    Found in src/LaraCart.php - About 6 hrs to fix

      Function updateDiscounts has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

          private function updateDiscounts()
    {
        // reset discounted
        foreach ($this->getItems() as $item) {
            $item->discounted = [];
      Severity: Minor
      Found in src/LaraCart.php - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      CartItem has 23 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class CartItem
{
    const ITEM_ID = 'id';
    const ITEM_QTY = 'qty';
    const ITEM_TAX = 'tax';
      Severity: Minor
      Found in src/CartItem.php - About 2 hrs to fix

        Function __set has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __set($option, $value)
    {
        switch ($option) {
            case CartItem::ITEM_QTY:
                if (!is_numeric($value) || $value <= 0) {
        Severity: Minor
        Found in src/Traits/CartOptionsMagicMethodsTrait.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method taxSummary has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function taxSummary()
    {
        $taxed = [];
        // tax item by item
        for ($qty = 0; $qty < $this->qty; $qty++) {
        Severity: Minor
        Found in src/CartItem.php - About 1 hr to fix

          Method add has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function add(
        $itemID,
        $name = null,
        $qty = 1,
        $price = '0.00',
          Severity: Minor
          Found in src/LaraCart.php - About 1 hr to fix

            Method __set has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function __set($option, $value)
    {
        switch ($option) {
            case CartItem::ITEM_QTY:
                if (!is_numeric($value) || $value <= 0) {
            Severity: Minor
            Found in src/Traits/CartOptionsMagicMethodsTrait.php - About 1 hr to fix

              Function feeTaxSummary has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function feeTaxSummary()
    {
        $taxed = [];
        if (config('laracart.fees_taxable', false)) {
            foreach ($this->getFees() as $fee) {
              Severity: Minor
              Found in src/LaraCart.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method updateDiscounts has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function updateDiscounts()
    {
        // reset discounted
        foreach ($this->getItems() as $item) {
            $item->discounted = [];
              Severity: Minor
              Found in src/LaraCart.php - About 1 hr to fix

                Function taxSummary has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function taxSummary()
    {
        $taxed = [];
        foreach ($this->getItems() as $item) {
            foreach ($item->taxSummary() as $taxRate => $amount) {
                Severity: Minor
                Found in src/LaraCart.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method add has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        $itemID,
        $name = null,
        $qty = 1,
        $price = '0.00',
        $options = [],
                Severity: Major
                Found in src/Contracts/LaraCartContract.php - About 50 mins to fix

                  Method add has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          $itemID,
        $name = null,
        $qty = 1,
        $price = '0.00',
        $options = [],
                  Severity: Major
                  Found in src/LaraCart.php - About 50 mins to fix

                    Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function __construct($id, $name, $qty, $price, $options = [], $taxable = true, $lineItem = false)
                    Severity: Major
                    Found in src/CartItem.php - About 50 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function subTotal($format = true)
    {
        $total = 0;

        if ($this->count() != 0) {
                      Severity: Minor
                      Found in src/LaraCart.php and 1 other location - About 50 mins to fix
                      src/LaraCart.php on lines 692..707

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 97.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public function itemTotals($format = true)
    {
        $total = 0;

        if ($this->count() != 0) {
                      Severity: Minor
                      Found in src/LaraCart.php and 1 other location - About 50 mins to fix
                      src/LaraCart.php on lines 716..731

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 97.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method addLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public function addLine($itemID, $name = null, $qty = 1, $price = '0.00', $options = [], $taxable = true)
                      Severity: Minor
                      Found in src/LaraCart.php - About 45 mins to fix

                        Method addLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function addLine($itemID, $name = null, $qty = 1, $price = '0.00', $options = [], $taxable = true);
                        Severity: Minor
                        Found in src/Contracts/LaraCartContract.php - About 45 mins to fix

                          Function add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function add(
        $itemID,
        $name = null,
        $qty = 1,
        $price = '0.00',
                          Severity: Minor
                          Found in src/LaraCart.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language