Sign upLogin

lulibrary/linked_research_metadata

View on GitHub
Star

Showing 12 of 12 total issues

Method roles has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

      def roles
        all_persons = []
        all_persons << @resource.persons_internal
        all_persons << @resource.persons_external
        all_persons << @resource.persons_other
Severity: Minor
Found in lib/linked_research_metadata/transformer/dataset.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method roles has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

      def roles
        all_persons = []
        all_persons << @resource.persons_internal
        all_persons << @resource.persons_external
        all_persons << @resource.persons_other
Severity: Minor
Found in lib/linked_research_metadata/transformer/project.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def projects
        @resource.projects.each do |i|
          @identifiers[:project] << i.uuid
          project_uri = RDF::URI.new(mint_uri(i.uuid, :project))
          add_triple @resource_uri, RDF::Vocab::DC.relation, project_uri
Severity: Major
Found in lib/linked_research_metadata/transformer/dataset.rb and 1 other location - About 1 hr to fix
lib/linked_research_metadata/transformer/person.rb on lines 29..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def affiliations
        @resource.affiliations.each do |i|
          @identifiers[:organisation] << i.uuid
          organisation_uri = RDF::URI.new(mint_uri(i.uuid, :organisation))
          add_triple @resource_uri, RDF::Vocab::MADS.hasAffiliation, organisation_uri
Severity: Major
Found in lib/linked_research_metadata/transformer/person.rb and 1 other location - About 1 hr to fix
lib/linked_research_metadata/transformer/dataset.rb on lines 94..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method roles has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def roles
        all_persons = []
        all_persons << @resource.persons_internal
        all_persons << @resource.persons_external
        all_persons << @resource.persons_other
Severity: Minor
Found in lib/linked_research_metadata/transformer/dataset.rb - About 1 hr to fix

    Method roles has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def roles
        all_persons = []
        all_persons << @resource.persons_internal
        all_persons << @resource.persons_external
        all_persons << @resource.persons_other
    Severity: Minor
    Found in lib/linked_research_metadata/transformer/project.rb - About 1 hr to fix

      Method files has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

            def files
        @resource.files.each do |i|
          file_uri = RDF::URI.new(mint_uri(SecureRandom.uuid, :file))

          add_triple @resource_uri, RDF::Vocab::DC.hasPart, file_uri
      Severity: Minor
      Found in lib/linked_research_metadata/transformer/dataset.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method projects has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def projects
        @resource.projects.each do |i|
          @identifiers[:project] << i.uuid
          project_uri = RDF::URI.new(mint_uri(i.uuid, :project))
          add_triple @resource_uri, RDF::Vocab::DC.relation, project_uri
      Severity: Minor
      Found in lib/linked_research_metadata/transformer/dataset.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method affiliations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def affiliations
        @resource.affiliations.each do |i|
          @identifiers[:organisation] << i.uuid
          organisation_uri = RDF::URI.new(mint_uri(i.uuid, :organisation))
          add_triple @resource_uri, RDF::Vocab::MADS.hasAffiliation, organisation_uri
      Severity: Minor
      Found in lib/linked_research_metadata/transformer/person.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method temporal has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def temporal
        t = @resource.temporal
        temporal_range = ''
        if t
          if t.start
      Severity: Minor
      Found in lib/linked_research_metadata/transformer/dataset.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def created
        object =  @resource.created
        if object
          object_literal = RDF::Literal.new(object.strftime("%F"), datatype: RDF::XSD.date)
          add_triple @resource_uri, RDF::Vocab::DC.created, object_literal
      Severity: Minor
      Found in lib/linked_research_metadata/transformer/dataset.rb and 1 other location - About 20 mins to fix
      lib/linked_research_metadata/transformer/dataset.rb on lines 29..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            def available
        object = @resource.available
        if object
          object_literal = RDF::Literal.new(object.strftime("%F"), datatype: RDF::XSD.date)
          add_triple @resource_uri, RDF::Vocab::DC.available, object_literal
      Severity: Minor
      Found in lib/linked_research_metadata/transformer/dataset.rb and 1 other location - About 20 mins to fix
      lib/linked_research_metadata/transformer/dataset.rb on lines 37..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language