Sign upLogin

lulibrary/preservation

View on GitHub
Star

Showing 10 of 10 total issues

Method package_metadata has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

      def package_metadata(d, f)
          o = {}
          o['filename'] = 'objects/' + f.name
          o['dc.title'] = d.title
          if d.description
Severity: Minor
Found in lib/preservation/transfer/dataset.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method package_metadata has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def package_metadata(d, f)
          o = {}
          o['filename'] = 'objects/' + f.name
          o['dc.title'] = d.title
          if d.description
Severity: Major
Found in lib/preservation/transfer/dataset.rb - About 3 hrs to fix

    Method prepare has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

          def prepare(uuid: nil,
                  dir_scheme: :uuid,
                  delay: 0)
        success = false
    Severity: Minor
    Found in lib/preservation/transfer/dataset.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method prepare has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def prepare(uuid: nil,
                  dir_scheme: :uuid,
                  delay: 0)
        success = false
    Severity: Major
    Found in lib/preservation/transfer/dataset.rb - About 2 hrs to fix

      Method build_directory_name has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def self.build_directory_name(metadata_record, directory_name_scheme)
      doi = metadata_record[:doi]
      uuid = metadata_record[:uuid]
      title = metadata_record[:title].strip.gsub(' ', '-').gsub('/', '-')
      time = Time.new
      Severity: Minor
      Found in lib/preservation/builder.rb - About 1 hr to fix

        Method row_to_hash has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.row_to_hash(row)
        id = row['id']
        uuid = row['uuid']
        # Archivematica stores path as BLOB, so need to convert path to Hex, to search for it
        # and use hex function in DB query
        Severity: Minor
        Found in lib/preservation/report/transfer.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method pending has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def self.pending
        entries = Dir.entries Preservation.ingest_path
        dirs = []
        entries.each do |entry|
          path = File.join(Preservation.ingest_path, entry)
        Severity: Minor
        Found in lib/preservation/report/transfer.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                if !dir_name.nil? &&
           !dir_name.empty? &&
           !Preservation::Report::Transfer.in_db?(dir_name) &&
           d.doi &&
           !d.files.empty? &&
        Severity: Major
        Found in lib/preservation/transfer/dataset.rb - About 40 mins to fix

          Method prepare_batch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def prepare_batch(max: nil,
                        dir_scheme: :uuid,
                        delay: 30)
        collection_extractor = Puree::Extractor::Collection.new config:   @config,
                                                                resource: :dataset
          Severity: Minor
          Found in lib/preservation/transfer/dataset.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method build_directory_name has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              def self.build_directory_name(metadata_record, directory_name_scheme)
      doi = metadata_record[:doi]
      uuid = metadata_record[:uuid]
      title = metadata_record[:title].strip.gsub(' ', '-').gsub('/', '-')
      time = Time.new
          Severity: Minor
          Found in lib/preservation/builder.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language