Sign upLogin

lulibrary/research_metadata

View on GitHub
Star

Showing 12 of 12 total issues

Method person has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

      def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
Severity: Minor
Found in lib/research_metadata/transformer/research_output.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method person has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

      def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
Severity: Minor
Found in lib/research_metadata/transformer/dataset.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method person has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
Severity: Minor
Found in lib/research_metadata/transformer/research_output.rb - About 1 hr to fix

    Method person has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
    Severity: Minor
    Found in lib/research_metadata/transformer/dataset.rb - About 1 hr to fix

      Method dates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def dates
        a = []

        available = @dataset.available
        if available
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if pure_role == 'Creator'
              human = ::Datacite::Mapping::Creator.new name: name
            else
              pure_role = 'Other' if pure_role === 'Contributor'
              contributor_type = ::Datacite::Mapping::ContributorType.find_by_value pure_role
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb and 1 other location - About 40 mins to fix
      lib/research_metadata/transformer/research_output.rb on lines 129..137

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if role == 'Creator'
              human = ::Datacite::Mapping::Creator.new name: name
            else
              role = 'Other' if pure_role === 'Contributor'
              contributor_type = ::Datacite::Mapping::ContributorType.find_by_value role
      Severity: Minor
      Found in lib/research_metadata/transformer/research_output.rb and 1 other location - About 40 mins to fix
      lib/research_metadata/transformer/dataset.rb on lines 156..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 37.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method related_identifiers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def related_identifiers
        research_outputs = @dataset.research_outputs
        data = []
        research_outputs.each do |i|
          # Skip as the relationship cannot currently be determined
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    if individual.uuid
                person_extractor = Puree::Extractor::Person.new @config
                person = person_extractor.find individual.uuid
                if person
                  identifier = name_identifier_orcid person
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb and 1 other location - About 35 mins to fix
      lib/research_metadata/transformer/research_output.rb on lines 140..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    if individual.uuid
                person_extractor = Puree::Extractor::Person.new @config
                person = person_extractor.find individual.uuid
                if person
                  identifier = name_identifier_orcid person
      Severity: Minor
      Found in lib/research_metadata/transformer/research_output.rb and 1 other location - About 35 mins to fix
      lib/research_metadata/transformer/dataset.rb on lines 167..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            def rights_list(files)
        arr = []
        files.each do |i|
          if i.license
            rights = Datacite::Mapping::Rights.new value: i.license.name
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb and 1 other location - About 25 mins to fix
      lib/research_metadata/transformer/research_output.rb on lines 65..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            def rights_list(files)
        arr = []
        files.each do |i|
          if i.license
            rights = Datacite::Mapping::Rights.new value: i.license.name
      Severity: Minor
      Found in lib/research_metadata/transformer/research_output.rb and 1 other location - About 25 mins to fix
      lib/research_metadata/transformer/dataset.rb on lines 65..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language