Sign upLogin

lulibrary/research_metadata

View on GitHub
Star

Showing 6 of 12 total issues

Method person has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
Open

      def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
Severity: Minor
Found in lib/research_metadata/transformer/research_output.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method person has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

      def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
Severity: Minor
Found in lib/research_metadata/transformer/dataset.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method person has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
Severity: Minor
Found in lib/research_metadata/transformer/research_output.rb - About 1 hr to fix

    Method person has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def person
        o = {}
        o['creator'] = []
        o['contributor'] = []
        all_persons = []
    Severity: Minor
    Found in lib/research_metadata/transformer/dataset.rb - About 1 hr to fix

      Method dates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def dates
        a = []

        available = @dataset.available
        if available
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method related_identifiers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def related_identifiers
        research_outputs = @dataset.research_outputs
        data = []
        research_outputs.each do |i|
          # Skip as the relationship cannot currently be determined
      Severity: Minor
      Found in lib/research_metadata/transformer/dataset.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language