Sign upLogin

lulibrary/research_metadata_announcement

View on GitHub
Star

Showing 3 of 3 total issues

Method transform has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

      def transform(id:, composition: [:new, :title, :hashtags, :uri],
                    max_length: nil, max_descriptors: 2)
        composition.uniq!

        @resource = @resource_extractor.find id
Severity: Minor
Found in lib/research_metadata_announcement/transformer/base.rb - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method transform has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def transform(id:, composition: [:new, :title, :hashtags, :uri],
                    max_length: nil, max_descriptors: 2)
        composition.uniq!

        @resource = @resource_extractor.find id
Severity: Major
Found in lib/research_metadata_announcement/transformer/base.rb - About 2 hrs to fix

    Method prepare_uri has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def prepare_uri
        uri = strip_uri_scheme @resource.doi if @resource && @resource.doi
        return unless uri
        resolver = 'doi.org'
        if uri.include? resolver
    Severity: Minor
    Found in lib/research_metadata_announcement/transformer/base.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language