Sign upLogin

lumoslabs/pester

View on GitHub
Star

Showing 3 of 3 total issues

Method retry_action has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  def retry_action(opts = {}, &block)
    merge_defaults(opts)
    if opts[:retry_error_classes] && opts[:reraise_error_classes]
      fail 'You can only have one of retry_error_classes or reraise_error_classes'
    end
Severity: Minor
Found in lib/pester.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge_defaults has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def merge_defaults(opts)
    opts[:retry_error_classes]      = opts[:retry_error_classes] ? Array(opts[:retry_error_classes]) : nil
    opts[:retry_error_messages]     = opts[:retry_error_messages] ? Array(opts[:retry_error_messages]) : nil
    opts[:reraise_error_classes]    = opts[:reraise_error_classes] ? Array(opts[:reraise_error_classes]) : nil
    opts[:max_attempts]             ||= 4
Severity: Minor
Found in lib/pester.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method should_retry? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def should_retry?(e, opts = {})
    retry_error_classes   = opts[:retry_error_classes]
    retry_error_messages  = opts[:retry_error_messages]
    reraise_error_classes = opts[:reraise_error_classes]
Severity: Minor
Found in lib/pester.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language