Showing 10 of 10 total issues
Function main
has 81 lines of code (exceeds 50 allowed). Consider refactoring. Open
func main() {
flag.Parse()
log := logger.NewBaseLogger(logger.LogLevel(*logLevel))
Function setupTcpListener
has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring. Open
func setupTcpListener(secure bool, log *logger.BaseLogger) {
var ln net.Listener
var err error
if secure {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function setupTcpListener
has 67 lines of code (exceeds 50 allowed). Consider refactoring. Open
func setupTcpListener(secure bool, log *logger.BaseLogger) {
var ln net.Listener
var err error
if secure {
Method WebForwarder.Start
has 63 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (fwd *WebForwarder) Start() {
if fwd.logger.LogLevel >= logger.Debug {
defer func(conn net.Conn) {
CloseConnectionDebug(conn)
}(fwd.srcConn)
Function main
has a Cognitive Complexity of 26 (exceeds 20 allowed). Consider refactoring. Open
func main() {
flag.Parse()
log := logger.NewBaseLogger(logger.LogLevel(*logLevel))
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function TLSGenerateConfig
has 51 lines of code (exceeds 50 allowed). Consider refactoring. Open
func TLSGenerateConfig() (serverTLSConf *tls.Config, clientTLSConf *tls.Config, err error) {
ca := TLSGenerateX509Cer(TLSCerTypeCA)
caPrivateKey, err := rsa.GenerateKey(rand.Reader, 4096)
if err != nil {
Function TLSGenerateConfig
has 6 return statements (exceeds 4 allowed). Open
func TLSGenerateConfig() (serverTLSConf *tls.Config, clientTLSConf *tls.Config, err error) {
ca := TLSGenerateX509Cer(TLSCerTypeCA)
caPrivateKey, err := rsa.GenerateKey(rand.Reader, 4096)
if err != nil {
Similar blocks of code found in 2 locations. Consider refactoring. Open
if p.logger.LogLevel >= logger.Debug {
defer func(conn net.Conn) {
tcp.CloseConnectionDebug(conn)
}(p.lConn)
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 103.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if p.logger.LogLevel >= logger.Debug {
defer func(conn net.Conn) {
tcp.CloseConnectionDebug(conn)
}(p.rConn)
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 103.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method Proxy.handleOutboundData
has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring. Open
func (p *Proxy) handleOutboundData(src, dst net.Conn, connBuff *[]byte) {
if p.lInitialized {
return
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"