Sign upLogin

luyadev/luya-headless

View on GitHub
Star

Showing 11 of 11 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function imageUpload(Client $client, $source, $type, $name, $folderId = 0, $isHidden = true)
    {
        // ensure file exists and is file
        if (!file_exists($source) || !is_file($source)) {
            return false;
Severity: Major
Found in src/modules/admin/ApiAdminStorage.php and 1 other location - About 4 hrs to fix
src/modules/admin/ApiAdminStorage.php on lines 46..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 173.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public static function fileUpload(Client $client, $source, $type, $name, $folderId = 0, $isHidden = true)
    {
        // ensure file exists and is file
        if (!file_exists($source) || !is_file($source)) {
            return false;
Severity: Major
Found in src/modules/admin/ApiAdminStorage.php and 1 other location - About 4 hrs to fix
src/modules/admin/ApiAdminStorage.php on lines 93..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 173.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

AbstractRequestClient has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class AbstractRequestClient
{
    const STATUS_CODE_UNAUTHORIZED = 401;
    
    const STATUS_CODE_FORBIDDEN = 403;
Severity: Minor
Found in src/base/AbstractRequestClient.php - About 3 hrs to fix

    AbstractEndpointRequest has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class AbstractEndpointRequest
{
    /**
     * @var EndpointInterface
     */
    Severity: Minor
    Found in src/base/AbstractEndpointRequest.php - About 2 hrs to fix

      Function jsonDecode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function jsonDecode($json)
    {
        if ($json === null || $json == '') {
            throw new RequestException(sprintf('API "%s" responded with an empty response content.', $this->getRequestUrl()));
        }
      Severity: Minor
      Found in src/base/AbstractRequestClient.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method jsonDecode has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function jsonDecode($json)
    {
        if ($json === null || $json == '') {
            throw new RequestException(sprintf('API "%s" responded with an empty response content.', $this->getRequestUrl()));
        }
      Severity: Minor
      Found in src/base/AbstractRequestClient.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($url, array $data, $statusCode, $content, $type, AbstractRequestClient $requestClient)
        Severity: Minor
        Found in src/base/AfterRequestEvent.php - About 45 mins to fix

          Function addItems has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addItems(array $items, $keyColumn)
    {
        foreach ($items as $key => $item) {
            if (!is_array($item)) {
                throw new Exception(sprintf('The given iterator item must be type of array in order to assign them to "%s" model.', $this->modelClass));
          Severity: Minor
          Found in src/base/BaseIterator.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method fileUpload has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static function fileUpload(Client $client, $source, $type, $name, $folderId = 0, $isHidden = true)
          Severity: Minor
          Found in src/modules/admin/ApiAdminStorage.php - About 45 mins to fix

            Method imageUpload has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static function imageUpload(Client $client, $source, $type, $name, $folderId = 0, $isHidden = true)
            Severity: Minor
            Found in src/modules/admin/ApiAdminStorage.php - About 45 mins to fix

              Function getPlaceholder has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getPlaceholder($name)
    {
        foreach ($this->__placeholders as $cols) {
            foreach ($cols as $col) {
                if ($col['var'] == $name) {
              Severity: Minor
              Found in src/modules/cms/models/NavItemPageBlock.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language