Showing 9 of 11 total issues
AbstractRequestClient
has 30 functions (exceeds 20 allowed). Consider refactoring. Open
abstract class AbstractRequestClient
{
const STATUS_CODE_UNAUTHORIZED = 401;
const STATUS_CODE_FORBIDDEN = 403;
AbstractEndpointRequest
has 24 functions (exceeds 20 allowed). Consider refactoring. Open
abstract class AbstractEndpointRequest
{
/**
* @var EndpointInterface
*/
Function jsonDecode
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function jsonDecode($json)
{
if ($json === null || $json == '') {
throw new RequestException(sprintf('API "%s" responded with an empty response content.', $this->getRequestUrl()));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method jsonDecode
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function jsonDecode($json)
{
if ($json === null || $json == '') {
throw new RequestException(sprintf('API "%s" responded with an empty response content.', $this->getRequestUrl()));
}
Method imageUpload
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public static function imageUpload(Client $client, $source, $type, $name, $folderId = 0, $isHidden = true)
Function addItems
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public function addItems(array $items, $keyColumn)
{
foreach ($items as $key => $item) {
if (!is_array($item)) {
throw new Exception(sprintf('The given iterator item must be type of array in order to assign them to "%s" model.', $this->modelClass));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fileUpload
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public static function fileUpload(Client $client, $source, $type, $name, $folderId = 0, $isHidden = true)
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct($url, array $data, $statusCode, $content, $type, AbstractRequestClient $requestClient)
Function getPlaceholder
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function getPlaceholder($name)
{
foreach ($this->__placeholders as $cols) {
foreach ($cols as $col) {
if ($col['var'] == $name) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"