luyadev/luya-module-admin

View on GitHub
src/apis/StorageController.php

Summary

Maintainability
C
1 day
Test Coverage
F
17%

Showing 5 of 5 total issues

File StorageController.php has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
 
namespace luya\admin\apis;
 
use InvalidArgumentException;
Severity: Minor
Found in src/apis/StorageController.php - About 4 hrs to fix

    StorageController has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class StorageController extends RestController
    {
    use CacheableTrait;
     
    /**
    Severity: Minor
    Found in src/apis/StorageController.php - About 2 hrs to fix

      Function actionFileReplace has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      public function actionFileReplace()
      {
      $fileId = Yii::$app->request->post('fileId', false);
      $raw = $_FILES['file'] ?? false;
      /** @var $file \luya\admin\file\Item */
      Severity: Minor
      Found in src/apis/StorageController.php - About 1 hr to fix

      Function actionFilesUpload has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      public function actionFilesUpload()
      {
      foreach ($_FILES as $k => $file) {
      if ($file['error'] !== UPLOAD_ERR_OK) {
      Yii::$app->response->setStatusCode(422, 'Data Validation Failed.');
      Severity: Minor
      Found in src/apis/StorageController.php - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

      return ['upload' => false, 'message' => Storage::getUploadErrorMessage(UPLOAD_ERR_NO_FILE), 'file' => null, 'queueIds' => []];
      Severity: Major
      Found in src/apis/StorageController.php - About 30 mins to fix
        Category
        Status