Function actionTwofaToken
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
public function actionTwofaToken()
{
if (($lockout = $this->sessionBruteForceLock(Yii::$app->session->get('secureId')))) {
return $this->sendArray(false, [Module::t('login_async_submission_limit_reached', ['time' => Yii::$app->formatter->asRelativeTime($lockout)])]);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function actionAsync
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public function actionAsync()
{
if (($lockout = $this->sessionBruteForceLock(0))) {
return $this->sendArray(false, [Module::t('login_async_submission_limit_reached', ['time' => Yii::$app->formatter->asRelativeTime($lockout)])]);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File LoginController.php
has 273 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace luya\admin\controllers;
use luya\admin\assets\Login;
Function actionReset
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function actionReset()
{
if (!$this->module->resetPassword) {
throw new ForbiddenHttpException();
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method actionTwofaToken
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionTwofaToken()
{
if (($lockout = $this->sessionBruteForceLock(Yii::$app->session->get('secureId')))) {
return $this->sendArray(false, [Module::t('login_async_submission_limit_reached', ['time' => Yii::$app->formatter->asRelativeTime($lockout)])]);
}
Method actionReset
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionReset()
{
if (!$this->module->resetPassword) {
throw new ForbiddenHttpException();
}
Method actionAsync
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionAsync()
{
if (($lockout = $this->sessionBruteForceLock(0))) {
return $this->sendArray(false, [Module::t('login_async_submission_limit_reached', ['time' => Yii::$app->formatter->asRelativeTime($lockout)])]);
}
Method actionPasswordReset
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function actionPasswordReset($token, $id)
{
if (!$this->module->resetPassword) {
throw new ForbiddenHttpException();
}
Function sessionBruteForceLock
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function sessionBruteForceLock($userId)
{
if (empty($userId)) {
// block all request from this IP
$userId = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sendArray
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private function sendArray($refresh, array $errors = [], $enterSecureToken = false, $message = null, $enterTwoFaToken = false)
Function actionPasswordReset
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function actionPasswordReset($token, $id)
{
if (!$this->module->resetPassword) {
throw new ForbiddenHttpException();
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function actionAsyncToken
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function actionAsyncToken()
{
if (($lockout = $this->sessionBruteForceLock(Yii::$app->session->get('secureId')))) {
return $this->sendArray(false, [Module::t('login_async_submission_limit_reached', ['time' => Yii::$app->formatter->asRelativeTime($lockout)])]);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $this->sendArray(false, $model->getErrors(), false);
Avoid too many return
statements within this method. Open
return $this->sendArray(false, [Module::t('login_async_twofa_verify_error')]);
Avoid too many return
statements within this method. Open
return $this->sendArray(true);
Avoid too many return
statements within this method. Open
return $this->sendArray(false, [Module::t('login_async_token_globalerror')]);
Identical blocks of code found in 2 locations. Consider refactoring. Open
if ($twoFa->verifyCode($user->login_2fa_secret, $verify)) {
$autologin = Yii::$app->session->get('autologin', false);
if (!$autologin) {
// auto login is disabled, disable the function
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
if (Yii::$app->security->validatePassword($backupCode, $user->login_2fa_backup_key)) {
$autologin = Yii::$app->session->get('autologin', false);
if (!$autologin) {
// auto login is disabled, disable the function
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 105.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76