Sign upLogin

luyadev/luya-module-admin

View on GitHub
Star
src/helpers/Storage.php

Summary

Maintainability
B
4 hrs
Test Coverage
F
42%

Function extractFilesDataFromMultipleFiles has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function extractFilesDataFromMultipleFiles(array $files)
    {
        $data = [];
        $i = 0;
        foreach ($files as $type => $field) {
Severity: Minor
Found in src/helpers/Storage.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function extractFilesDataFromFilesArray has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static function extractFilesDataFromFilesArray(array $file)
    {
        if (!isset($file['tmp_name'])) {
            return [];
        }
Severity: Minor
Found in src/helpers/Storage.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extractFilesDataFromFilesArray has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function extractFilesDataFromFilesArray(array $file)
    {
        if (!isset($file['tmp_name'])) {
            return [];
        }
Severity: Minor
Found in src/helpers/Storage.php - About 1 hr to fix

    Function removeImage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function removeImage($imageId, $cleanup = false)
    {
        Yii::$app->storage->flushArrays();
        $image = Yii::$app->storage->getImage($imageId);
        if ($cleanup && $image) {
    Severity: Minor
    Found in src/helpers/Storage.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function removeFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function removeFile($fileId, $cleanup = false)
    {
        $model = StorageFile::find()->where(['id' => $fileId, 'is_deleted' => false])->one();
        if ($model) {
            if ($cleanup) {
    Severity: Minor
    Found in src/helpers/Storage.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status