luyadev/luya-module-admin

View on GitHub
src/models/User.php

Summary

Maintainability
C
1 day
Test Coverage
B
82%

User has 41 functions (exceeds 20 allowed). Consider refactoring.
Open

class User extends NgRestModel implements IdentityInterface, ChangePasswordInterface
{
    use SoftDeleteTrait;
    public const USER_SETTING_ISDEVELOPER = 'isDeveloper';

Severity: Minor
Found in src/models/User.php - About 5 hrs to fix

    File User.php has 352 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace luya\admin\models;
    
    use luya\admin\aws\ApiRequestInsightActiveWindow;
    Severity: Minor
    Found in src/models/User.php - About 4 hrs to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in src/models/User.php - About 30 mins to fix

        Function findIdentityByAccessToken has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function findIdentityByAccessToken($token, $type = null)
            {
                if (empty($token) || !is_scalar($token)) {
                    throw new InvalidArgumentException("The provided access token is invalid.");
                }
        Severity: Minor
        Found in src/models/User.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status