luyadev/luya-module-cms

View on GitHub
src/admin/apis/NavItemController.php

Summary

Maintainability
F
3 days
Test Coverage
F
5%

File NavItemController.php has 372 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace luya\cms\admin\apis;

use luya\cms\admin\Module;
Severity: Minor
Found in src/admin/apis/NavItemController.php - About 4 hrs to fix

    Function actionUpdatePageItem has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        public function actionUpdatePageItem($navItemId, $navItemType): array|bool
        {
            $model = NavItem::findOne($navItemId);
    
            if (!$model) {
    Severity: Minor
    Found in src/admin/apis/NavItemController.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method actionUpdatePageItem has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function actionUpdatePageItem($navItemId, $navItemType): array|bool
        {
            $model = NavItem::findOne($navItemId);
    
            if (!$model) {
    Severity: Major
    Found in src/admin/apis/NavItemController.php - About 4 hrs to fix

      NavItemController has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class NavItemController extends \luya\admin\base\RestController
      {
          /**
           * @inheritdoc
           */
      Severity: Minor
      Found in src/admin/apis/NavItemController.php - About 2 hrs to fix

        Function actionGetNavItemPath has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function actionGetNavItemPath($navId)
            {
                $data = "";
                $node = NavItem::find()->where(['nav_id' => $navId])->one();
                if ($node) {
        Severity: Minor
        Found in src/admin/apis/NavItemController.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method actionCreatePageVersion has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function actionCreatePageVersion()
            {
                $fromPageModel = null;
                $name = Yii::$app->request->post('name');
                $fromPageId = (int) Yii::$app->request->post('fromPageId');
        Severity: Minor
        Found in src/admin/apis/NavItemController.php - About 1 hr to fix

          Function actionCreatePageVersion has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function actionCreatePageVersion()
              {
                  $fromPageModel = null;
                  $name = Yii::$app->request->post('name');
                  $fromPageId = (int) Yii::$app->request->post('fromPageId');
          Severity: Minor
          Found in src/admin/apis/NavItemController.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                                  if ($parentNavId) {
                                      $data = $node->title . '/' . $data;
                                  }
          Severity: Major
          Found in src/admin/apis/NavItemController.php - About 45 mins to fix

            Avoid too many return statements within this method.
            Open

                                    return $this->sendModelError($typeModel);
            Severity: Major
            Found in src/admin/apis/NavItemController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return false;
              Severity: Major
              Found in src/admin/apis/NavItemController.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return [
                                'item' => $model,
                                'typeData' => ($model->nav_item_type == 1) ? NavItemPage::getVersionList($model->id) : $model->getType()->toArray()
                            ];
                Severity: Major
                Found in src/admin/apis/NavItemController.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return $this->sendModelError($typeModel);
                  Severity: Major
                  Found in src/admin/apis/NavItemController.php - About 30 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    case NavItem::TYPE_REDIRECT:
                                        $typeModel = new NavItemRedirect();
                                        $this->setPostAttribute($typeModel, 'type');
                                        $this->setPostAttribute($typeModel, 'value');
                                        $this->setPostAttribute($typeModel, 'target');
                    Severity: Major
                    Found in src/admin/apis/NavItemController.php and 1 other location - About 1 hr to fix
                    src/admin/apis/NavItemController.php on lines 373..384

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 103.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    case NavItem::TYPE_MODULE:
                                        $typeModel = new NavItemModule();
                                        $this->setPostAttribute($typeModel, 'module_name');
                                        $this->setPostAttribute($typeModel, 'controller_name');
                                        $this->setPostAttribute($typeModel, 'action_name');
                    Severity: Major
                    Found in src/admin/apis/NavItemController.php and 1 other location - About 1 hr to fix
                    src/admin/apis/NavItemController.php on lines 385..396

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 103.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function actionMoveAfter($moveItemId, $droppedAfterItemId)
                        {
                            $result = Nav::moveToAfter($moveItemId, $droppedAfterItemId);
                    
                            if ($result !== true) {
                    Severity: Major
                    Found in src/admin/apis/NavItemController.php and 2 other locations - About 1 hr to fix
                    src/admin/apis/NavItemController.php on lines 452..462
                    src/admin/apis/NavItemController.php on lines 490..500

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function actionMoveBefore($moveItemId, $droppedBeforeItemId)
                        {
                            $result = Nav::moveToBefore($moveItemId, $droppedBeforeItemId);
                    
                            if ($result !== true) {
                    Severity: Major
                    Found in src/admin/apis/NavItemController.php and 2 other locations - About 1 hr to fix
                    src/admin/apis/NavItemController.php on lines 471..481
                    src/admin/apis/NavItemController.php on lines 490..500

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function actionMoveToChild($moveItemId, $droppedOnItemId)
                        {
                            $result = Nav::moveToChild($moveItemId, $droppedOnItemId);
                    
                            if ($result !== true) {
                    Severity: Major
                    Found in src/admin/apis/NavItemController.php and 2 other locations - About 1 hr to fix
                    src/admin/apis/NavItemController.php on lines 452..462
                    src/admin/apis/NavItemController.php on lines 471..481

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 102.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status