luyadev/luya-module-cms

View on GitHub
src/admin/importers/CmslayoutImporter.php

Summary

Maintainability
C
1 day
Test Coverage
D
65%

Function importLayoutFile has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected function importLayoutFile($file, $aliased, $themeName = null)
    {
        if (!file_exists($file)) {
            return false;
        }
Severity: Minor
Found in src/admin/importers/CmslayoutImporter.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method importLayoutFile has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function importLayoutFile($file, $aliased, $themeName = null)
    {
        if (!file_exists($file)) {
            return false;
        }
Severity: Major
Found in src/admin/importers/CmslayoutImporter.php - About 2 hrs to fix

    Function comparePlaceholders has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function comparePlaceholders($array1, $array2)
        {
            if (!array_key_exists('placeholders', $array1) || !array_key_exists('placeholders', $array2)) {
                return false;
            }
    Severity: Minor
    Found in src/admin/importers/CmslayoutImporter.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function handleLayoutFile has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function handleLayoutFile(&$layoutFiles, $path, $themeName = null)
        {
            $aliased = Yii::getAlias($path, false);
            $filePath = $aliased ?: $path;
    
    
    Severity: Minor
    Found in src/admin/importers/CmslayoutImporter.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return true;
    Severity: Major
    Found in src/admin/importers/CmslayoutImporter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return false;
      Severity: Major
      Found in src/admin/importers/CmslayoutImporter.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status