Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star
src/models/NavItem.php

Summary

Maintainability
D
1 day
Test Coverage
F
45%

File NavItem.php has 316 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace luya\cms\models;

use luya\admin\base\GenericSearchInterface;
Severity: Minor
Found in src/models/NavItem.php - About 3 hrs to fix

    NavItem has 29 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class NavItem extends ActiveRecord implements GenericSearchInterface
{
    public const TYPE_PAGE = 1;

    public const TYPE_MODULE = 2;
    Severity: Minor
    Found in src/models/NavItem.php - About 3 hrs to fix

      Function copyPageItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function copyPageItem(NavItem $targetNavItem)
    {
        if ($this->nav_item_type !== self::TYPE_PAGE) {
            return false;
        }
      Severity: Minor
      Found in src/models/NavItem.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method copyPageItem has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function copyPageItem(NavItem $targetNavItem)
    {
        if ($this->nav_item_type !== self::TYPE_PAGE) {
            return false;
        }
      Severity: Minor
      Found in src/models/NavItem.php - About 1 hr to fix

        Function getType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getType(): \luya\cms\models\NavItemPage|\luya\cms\models\NavItemModule|\luya\cms\models\NavItemRedirect|bool
    {
        if ($this->_type === null) {
            // what kind of item type are we looking for
            if ($this->nav_item_type == self::TYPE_PAGE) {
        Severity: Minor
        Found in src/models/NavItem.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/models/NavItem.php - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function copyRedirectItem(NavItem $targetNavItem)
    {
        if ($this->nav_item_type !== self::TYPE_REDIRECT) {
            return false;
        }
          Severity: Major
          Found in src/models/NavItem.php and 1 other location - About 1 hr to fix
          src/models/NavItem.php on lines 478..497

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public function copyModuleItem(NavItem $targetNavItem)
    {
        if ($this->nav_item_type !== self::TYPE_MODULE) {
            return false;
        }
          Severity: Major
          Found in src/models/NavItem.php and 1 other location - About 1 hr to fix
          src/models/NavItem.php on lines 506..525

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status